[NT-485] Tracking event for Update Pledge #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update-pledge-event
cdolm92
commented
Oct 31, 2019
| @@ -96,6 +96,7 @@ public class PledgeViewModel: PledgeViewModelType, PledgeViewModelInputs, Pledge | |||
| let context = initialData.map { $0.3 } | |||
|
|
|||
| let backing = project.map { $0.personalization.backing }.skipNil() | |||
| let projectAndBacking = Signal.combineLatest(project, backing) | |||
There was a problem hiding this comment.
I don't need to use this anymore
| |> Backing.lens.status .~ .pledged | ||
| |> Backing.lens.shippingAmount .~ 10 | ||
| |> Backing.lens.amount .~ 700 | ||
| ) |
There was a problem hiding this comment.
I can remove this and just use the template.
| state: .successful, | ||
| backing: .init( | ||
| clientSecret: "client-secret", | ||
| requiresAction: true |
There was a problem hiding this comment.
going to default this to false b/c we're not testing SCA flow.
| updateBackingResult: .success(updateBackingEnvelope) | ||
| ) | ||
|
|
||
| withEnvironment(apiService: mockService, currentUser: .template) { |
There was a problem hiding this comment.
removing environment call and adding an additional test to test .updateReward context.
There was a problem hiding this comment.
Also added an additional test to make sure the tracking event is not triggered in changePaymentMethod context.
| @@ -3427,4 +3427,44 @@ final class PledgeViewModelTests: TestCase { | |||
| self.showErrorBannerWithMessage.assertDidNotEmitValue() | |||
| } | |||
| } | |||
|
|
|||
| func testTrackingEvents() { | |||
There was a problem hiding this comment.
Rename to testTrackingEvents_ContextIsUpdate()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Improvements in monitoring user behavior for v1 checkout. This tracks updated pledges.
🤔 Why
We now have the
Update Pledge Button Clickedevent.✅ Acceptance criteria
Note: Update Pledge Event should not trigger when changing a payment method
Update Pledge. Change your pledge amount and tapConfirm, you should see the"Update Pledge Button Clicked"triggered.Update Pledge. Change your shipping location and tapConfirm, you should see the"Update Pledge Button Clicked"triggered.Choose another reward. Change your reward and tapSelect, then tapConfirm, you should see the"Update Pledge Button Clicked"triggered.