[NT-486] Tracking event for Update Payment Method #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdolm92
changed the title
cdolm92
commented
Oct 31, 2019
|
|
||
| //Tracking | ||
| projectAndPledgeAmount | ||
| .filter { context, _, _ in context == .changePaymentMethod} |
There was a problem hiding this comment.
Change to .filter { $0.0 == .changePaymentMethod }
| @@ -548,6 +548,17 @@ public class PledgeViewModel: PledgeViewModelType, PledgeViewModelInputs, Pledge | |||
|
|
|||
| self.submitButtonTitle = context.map { $0.submitButtonTitle } | |||
| self.title = context.map { $0.title } | |||
| let projectAndPledgeAmount = Signal.combineLatest(context, project, pledgeAmount) | |||
There was a problem hiding this comment.
rename to contextAndProjectAndPledgeAmount
| updateBackingResult: .success(updateBackingEnvelope) | ||
| ) | ||
|
|
||
| withEnvironment(apiService: mockService, currentUser: .template) { |
There was a problem hiding this comment.
remove environment.
…update-payment-method-event
|
Thanks for approving, it will merge when tests pass. Fixed merge conflict and organized the tracking test a little better. |
…update-payment-method-event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Improvements in monitoring user behavior for v1 checkout. This tracks update payment methods.
🤔 Why
We now have the
Update Payment Method Button Clickedevent.✅ Acceptance criteria
Change Payment Method. Change your payment method and tapConfirm, you should see the"Update Payment Method Button Clicked"triggered.