[NT-562] Disable reverse animation #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scollaco
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Temporarily disables the reverse animation for
PledgeViewControllertoRewardsCollectionViewController.🤔 Why
We need to fix the reverse transition and this looks a bit better for now.
🛠 How
@ifbarrera changed it to simply return
nilinstead ofRewardPledgePopTransitionAnimatorin the case of navigating back toRewardsCollectionViewController.✅ Acceptance criteria
PledgeViewControllertoRewardsCollectionViewControllerperforms a standard back animation instead of transitioning the thumbnail back to the carousel view.Note: There is a slight shadow that is briefly shown when the view pops. This is baked into UIKit and there doesn't appear to be any obvious way to get rid of it. When we fix the reverse transition in an upcoming release this will be a non-issue.