resolve #184 #196
Open
resolve #184 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this change on first glance looks good. Could you add a test in tests/org-gcal-test.el? I can help you if you need some help. |
|
Great, yes happy to have some help, never tested elisp code so far. I checked the org-gcal-test.el, but not sure to where to start ... sorry ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First, thanks for the great work ! Just started with org-gcal and pretty happy about it so far.
It's a tiny PR but this is my first emacs/elisp PR, so please bare with me if I missed obvious things and I'm all ears if there is more to add to it.