Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗃 Remove postgres id and use kf_id as primary key #105

Merged
merged 2 commits into from
Feb 8, 2018

Conversation

dankolbman
Copy link
Contributor

@dankolbman dankolbman commented Feb 7, 2018

Fixes #101

Now foreign relations are returned with the kf_id instead of the postgres id.

@dankolbman dankolbman self-assigned this Feb 7, 2018
@dankolbman dankolbman added the refactor Something needs to be done better label Feb 8, 2018
uuid = db.Column(db.String(36), unique=True, default=uuid_generator)
kf_id = db.Column(db.String(8), unique=True, default=kf_id_generator)
kf_id = db.Column(db.String(8), unique=True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need the unique=True bc its a primary key column

@dankolbman dankolbman merged commit 7d7c936 into master Feb 8, 2018
@dankolbman dankolbman deleted the kf_id-primary-key branch February 8, 2018 15:38
@dankolbman dankolbman mentioned this pull request Apr 2, 2018
alubneuski pushed a commit that referenced this pull request Oct 11, 2024
🗃 Remove postgres id and use kf_id as primary key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Something needs to be done better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants