Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🗃 Change uuid field to Postgres UUID #107

Merged
merged 2 commits into from
Feb 18, 2018
Merged

🗃 Change uuid field to Postgres UUID #107

merged 2 commits into from
Feb 18, 2018

Conversation

dankolbman
Copy link
Contributor

No description provided.

@dankolbman dankolbman added the refactor Something needs to be done better label Feb 7, 2018
@dankolbman dankolbman self-assigned this Feb 8, 2018
znatty22
znatty22 approved these changes Feb 8, 2018
View reviewed changes
Copy link
Member

@znatty22 znatty22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

parimalak
parimalak approved these changes Feb 17, 2018
View reviewed changes
Copy link
Contributor

@parimalak parimalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dankolbman
Copy link
Contributor Author

Needed to write a custom migration to cast the text field into uuid. The downgrade works without custom migration because it's trivial to cast the uuid back to text.

@dankolbman dankolbman merged commit a210adc into master Feb 18, 2018
@dankolbman dankolbman deleted the pg-uuid branch February 18, 2018 01:04
@dankolbman dankolbman mentioned this pull request Apr 2, 2018
Merged
alubneuski pushed a commit that referenced this pull request Oct 11, 2024
@dankolbman
Merge pull request #107 from kids-first/pg-uuid
a8a7ee8 
🗃 Change uuid field to Postgres UUID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znatty22 znatty22 znatty22 approved these changes

@parimalak parimalak parimalak approved these changes

Assignees

@dankolbman dankolbman

Labels
refactor Something needs to be done better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dankolbman @znatty22 @parimalak