✨ Add Controlled Access field to Genomic file entity #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parimalak
changed the title
parimalak
changed the title
dankolbman
reviewed
Feb 8, 2018
migrations/versions/f80726457a72_.py
Outdated
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision = 'f80726457a72' | ||
| down_revision = '0cc35a21afc2' |
There was a problem hiding this comment.
I believe this revision may need to be modified because of the new version added in the last merge
There was a problem hiding this comment.
If you change this to b7852f8aab0a I think you can get rid of the merge version.
parimalak
force-pushed
the
genomic-file-afield
branch
from
e4d57a7 to
3c69932
Compare
🗃️ Remove postgres id and use kf_id as primary key 🗃️ Add migration for new primary key
parimalak
force-pushed
the
genomic-file-afield
branch
from
3c69932 to
b269108
Compare
znatty22
changed the title
parimalak
changed the title
parimalak
changed the title
znatty22
reviewed
Feb 12, 2018
migrations/versions/1c790b83f611_.py
Outdated
| @@ -0,0 +1,30 @@ | |||
| """rename file_type to data_type for genomic_file | |||
There was a problem hiding this comment.
I know this is nit picking but can you change to:
"""
Rename file_type to data_type for genomic_file
Revision ID: 1c790b83f611
Revises: f80726457a72
Create Date: 2018-02-12 15:33:27.365798
"""
migrations/versions/f80726457a72_.py
Outdated
| @@ -0,0 +1,28 @@ | |||
| """Add Controlled_access field to genomic_file | |||
There was a problem hiding this comment.
Similar request as above, can you change to:
"""
Add Controlled_access field to genomic_file
Revision ID: f80726457a72
Revises: b7852f8aab0a
Create Date: 2018-02-07 16:12:38.279955
"""
migrations/versions/f80726457a72_.py
Outdated
| @@ -0,0 +1,28 @@ | |||
| """Add Controlled_access field to genomic_file | |||
|
|
|||
| Revision ID: f80726457a72 | |||
There was a problem hiding this comment.
I think you should be able to combine these two migration script into one. On your branch, you could do:
git reset origin/master migrations
rm migrations/versions/1c790b83f611_.py migrations/versions/f80726457a72_.py
# Make sure your dataservice containers are running, and if not run:
docker-compose up -d
# Generate new migration script
flask db migrate
That should generate a new migration script. Make sure you update the docstring to include both the field changes
parimalak
force-pushed
the
genomic-file-afield
branch
from
147d69f to
0e773df
Compare
dankolbman
approved these changes
Feb 13, 2018
|
✨ Update fields(controlled_access, data_type) in Genomic file entity |
Merged
alubneuski
pushed a commit
that referenced
this pull request
Oct 11, 2024
✨ Update fields(controlled_access, data_type) in Genomic file entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Controlled Access field to Genomic file entity.
Renamed file_type to data_type.
Updated dummy data generation script,migrations and tests