✨ Study model #130
Merged
✨ Study model #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znatty22
force-pushed
the
study-model
branch
from
920b87f to
ab4db52
Compare
dankolbman
reviewed
Feb 15, 2018
| nullable=False) | ||
|
|
||
| def __repr__(self): | ||
| return '<Participant {}>'.format(self.external_id) |
There was a problem hiding this comment.
Could we use kf_id here?
dataservice/api/study/models.py
Outdated
|
|
||
| data_access_authority = db.Column(db.Text(), | ||
| nullable=False, | ||
| default='dbGap') |
There was a problem hiding this comment.
technical stylized as dbGaP
dataservice/api/study/models.py
Outdated
| backref='study') | ||
|
|
||
| def __repr__(self): | ||
| return '<Study {}>'.format(self.external_id) |
parimalak
reviewed
Feb 15, 2018
| @@ -20,6 +21,9 @@ def create_participant_sample_aliquot(self): | |||
| create a participant, sample, and aliquot save to db | |||
There was a problem hiding this comment.
we could comment something about creating study
dankolbman
reviewed
Feb 16, 2018
migrations/versions/c23f9043d57b_.py
Outdated
| sa.UniqueConstraint('kf_id'), | ||
| sa.UniqueConstraint('uuid') | ||
| ) | ||
| op.create_unique_constraint(None, 'outcome', ['kf_id']) |
There was a problem hiding this comment.
Shouldn't be in this migration.
znatty22
force-pushed
the
study-model
branch
from
17ea009 to
62a4dac
Compare
znatty22
force-pushed
the
study-model
branch
from
62a4dac to
0d49386
Compare
parimalak
approved these changes
Feb 16, 2018
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add study model and one to many relation to participant
Add unit tests for study model
Add updates to all entity unit tests to support addition of study
Add entity relationship diagram
Add migrations