Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix self links #158

Merged
merged 1 commit into from
Mar 7, 2018
Merged

🐛 Fix self links #158

merged 1 commit into from
Mar 7, 2018
+25 −2

Conversation

dankolbman
Copy link
Contributor

  • Fixes formatting of the self link where a datetime was being used instead of a timestamp.
  • Fixes issue where the timestamp being returned for the current page did not have a small enough delta causing earlier results to be returned.

@dankolbman dankolbman added the bug Something isn't working label Mar 1, 2018
@dankolbman dankolbman self-assigned this Mar 1, 2018
@dankolbman dankolbman requested review from znatty22 and parimalak March 1, 2018 21:07
@dankolbman dankolbman force-pushed the pagination-timestamp branch from 4b83423 to 74e8988 Compare March 2, 2018 13:18
@dankolbman dankolbman force-pushed the pagination-timestamp branch from 74e8988 to ccf1f3c Compare March 6, 2018 19:17
znatty22
znatty22 approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@znatty22 znatty22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dankolbman dankolbman merged commit 71fcfbd into master Mar 7, 2018
@dankolbman dankolbman deleted the pagination-timestamp branch March 7, 2018 14:31
@dankolbman dankolbman changed the title 🐛 Fix self links 🐛 Fix self links Mar 9, 2018
@dankolbman dankolbman mentioned this pull request Apr 2, 2018
Merged
@dankolbman dankolbman removed the ready-for-review This PR needs a review label May 7, 2018
alubneuski pushed a commit that referenced this pull request Oct 11, 2024
@dankolbman
Merge pull request #158 from kids-first/pagination-timestamp
c966049 
 🐛 Fix self links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znatty22 znatty22

@parimalak parimalak

Assignees

@dankolbman dankolbman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dankolbman @znatty22 @parimalak