✨Add outcome endpoint #189
Merged
+419
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankolbman
reviewed
Mar 16, 2018
|
|
||
| def test_patch_bad_input(self): | ||
| """ | ||
| Test updating an existing participant with invalid input |
znatty22
reviewed
Mar 16, 2018
| OUTCOMES_LIST_URL = 'api.outcomes_list' | ||
|
|
||
|
|
||
| class OutcomeTest(FlaskTestCase): |
There was a problem hiding this comment.
We should merge #84 first and then you can probably remove a lot of these tests (bad input, missing req params) and put them in test_api.py.
parimalak
force-pushed
the
outcome-resource
branch
from
7b9d257 to
db6ff73
Compare
znatty22
reviewed
Mar 19, 2018
tests/test_api.py
Outdated
| @@ -105,6 +112,7 @@ def test_status_format(self, client, endpoint, method): | |||
| ('/samples', 'PATCH', ['created_at', 'modified_at']), | |||
| ('/studies', 'POST', ['created_at', 'modified_at']), | |||
| ('/studies', 'PATCH', ['created_at', 'modified_at']), | |||
| ('/outcomes', 'PATCH', ['created_at', 'modified_at']), | |||
There was a problem hiding this comment.
What about ('/outcomes', 'POST', ['created_at', 'modified_at'])
parimalak
force-pushed
the
outcome-resource
branch
from
7c03543 to
665d9f2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added outcome resources and schemas
Updated tests for outcome resource