-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Family relationship resource #194
Conversation
d13ce5a
to
25a71b7
Compare
25a71b7
to
8e67c7b
Compare
_links = ma.Hyperlinks({ | ||
'self': ma.URLFor(Meta.resource_url, kf_id='<kf_id>'), | ||
'collection': ma.URLFor(Meta.collection_url), | ||
'participant': ma.URLFor('api.participants', kf_id='<participant_id>'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we've discussed doing this in #104, but do we want to do it to all resources at once to stay consistent? How do we track?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welp, I think I might have added these types of links for the other resources I did...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh well, we'll just need to make sure the others get done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just need to fix the issue with the merge in the tests.
8e67c7b
to
4157b10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
✨Family relationship resource
Add CRUD endpoints for family relationship resource, unit tests, and updated docs
Addresses #167