Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Family relationship resource #194

Merged
merged 3 commits into from
Mar 22, 2018
Merged

Conversation

znatty22
Copy link
Member

Add CRUD endpoints for family relationship resource, unit tests, and updated docs

Addresses #167

@znatty22 znatty22 added the feature New functionality label Mar 19, 2018
@znatty22 znatty22 self-assigned this Mar 19, 2018
@znatty22 znatty22 force-pushed the family-relationship-resource branch from d13ce5a to 25a71b7 Compare March 19, 2018 21:01
@znatty22 znatty22 force-pushed the family-relationship-resource branch from 25a71b7 to 8e67c7b Compare March 19, 2018 21:34
_links = ma.Hyperlinks({
'self': ma.URLFor(Meta.resource_url, kf_id='<kf_id>'),
'collection': ma.URLFor(Meta.collection_url),
'participant': ma.URLFor('api.participants', kf_id='<participant_id>'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we've discussed doing this in #104, but do we want to do it to all resources at once to stay consistent? How do we track?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welp, I think I might have added these types of links for the other resources I did...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh well, we'll just need to make sure the others get done.

Copy link
Contributor

@dankolbman dankolbman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just need to fix the issue with the merge in the tests.

@znatty22 znatty22 force-pushed the family-relationship-resource branch from 8e67c7b to 4157b10 Compare March 21, 2018 20:46
Copy link
Contributor

@parimalak parimalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@znatty22 znatty22 changed the title Family relationship resource ✨Family relationship resource Mar 22, 2018
@znatty22 znatty22 merged commit c6d6589 into master Mar 22, 2018
@znatty22 znatty22 deleted the family-relationship-resource branch March 22, 2018 13:38
@dankolbman dankolbman mentioned this pull request Apr 2, 2018
@dankolbman dankolbman removed the ready-for-review This PR needs a review label May 7, 2018
alubneuski pushed a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants