✨Study file resource #197
✨Study file resource #197
Conversation
| _links = ma.Hyperlinks({ | ||
| 'self': ma.URLFor(Meta.resource_url, kf_id='<kf_id>'), | ||
| 'collection': ma.URLFor(Meta.collection_url), | ||
| 'study_files': ma.URLFor('api.studies', kf_id='<study_id>') |
There was a problem hiding this comment.
I think this should just be study?
There was a problem hiding this comment.
i dont know the usecase for having 'study' information in _links but, it is easier to get all the study_files from study as each study_file belong to one study. i am saying this because we can remove this line altogether from _links similar to what we did for investigator and study resources.
|
|
||
|
|
||
| class StudyFileTest(FlaskTestCase): | ||
| ''' |
There was a problem hiding this comment.
Small nit, but we should stay consistent with the use of double quotes for docstrings.
There was a problem hiding this comment.
yep i used study tests as reference i am gonna change for other resources as well👍
| _links = ma.Hyperlinks({ | ||
| 'self': ma.URLFor(Meta.resource_url, kf_id='<kf_id>'), | ||
| 'collection': ma.URLFor(Meta.collection_url), | ||
| 'study_files': ma.URLFor('api.studies', kf_id='<study_id>') |
There was a problem hiding this comment.
Should be singular:
'study_file': ma.URLFor('api.studies', kf_id='<study_id>')| self.assertEqual(study_file['kf_id'], kf_id) | ||
| self.assertEqual(study_file['file_name'], body['file_name']) | ||
|
|
||
| def test_patch_study_file_no_required_field(self): |
There was a problem hiding this comment.
Could probably remove this test since it's essentially the same as test_patch
tests/test_pagination.py
Outdated
| @@ -31,6 +32,12 @@ def participants(client): | |||
| db.session.add(s) | |||
| db.session.commit() | |||
|
|
|||
| # Add study files for studies | |||
| for _ in range(102): | |||
There was a problem hiding this comment.
Could probably create the study files and link the files to a study in the loop where you're creating each study
dankolbman
force-pushed
the
study-file-resource
branch
from
c92b896 to
a214931
Compare
parimalak
force-pushed
the
study-file-resource
branch
from
a214931 to
e6c6f24
Compare
parimalak
force-pushed
the
study-file-resource
branch
from
e6c6f24 to
ffcfca5
Compare
Added resources for study_file endpoint
Added tests for study_file endpoint
Resolves #197