🔧 Refactor code base to be modular for additional entities #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create common module for common code among resources Separate out model code, resource code, serialization code for Person resources Create new folder for person tests, move all person tests into it
dankolbman
reviewed
Jan 16, 2018
dataservice/api/__init__.py
Outdated
| from flask_restplus import Api | ||
| from .person import person_api | ||
|
|
||
| api = Api(title='Kids First Data Service', | ||
| api_v1 = Blueprint('api', __name__, url_prefix='/api/v1') |
There was a problem hiding this comment.
We'll probably host under api.kids-first.io. We can use /v1 for versioning, but let's drop the /api for now.
dataservice/api/common/model.py
Outdated
| @@ -1,9 +1,9 @@ | |||
| from sqlalchemy.ext.declarative import declared_attr | |||
|
|
|||
| from datetime import datetime | |||
| from . import db | |||
| from dataservice import db | |||
There was a problem hiding this comment.
why the change from relative to absolute imports? Should probably stay consistent throughout the code base.
There was a problem hiding this comment.
Ok as just discussed, we're going with absolute imports. Will make the necessary changes
dataservice/commands.py
Outdated
|
|
||
| HERE = os.path.abspath(os.path.dirname(__file__)) | ||
| PROJECT_ROOT = os.path.join(HERE, os.pardir) | ||
| TEST_PATH = os.path.join(PROJECT_ROOT, 'tests') |
There was a problem hiding this comment.
Are these used anywhere?
|
We can also remove flask-script from |
Remove unused constants in commands.py Remove deploy command - it is obsolete since flask CLI has a way to run db upgrade
znatty22
changed the title
znatty22
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.