♻️ Formatting responses and abstracting out some of the models #30
+153
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankolbman
changed the title
znatty22
reviewed
Jan 17, 2018
| 'message': 'person deleted', | ||
| 'content': {'persons': [person]}}, 200 | ||
|
|
||
| return kf_response(person, 200, 'person deleted') | ||
|
|
||
| def _not_found(self, kf_id): |
There was a problem hiding this comment.
One test is failing: test_get_not_found in tests > person > test_resources.
Change this method to the following to fix:
def _not_found(self, kf_id):
"""
Temporary helper - will do error handling better later
"""
return kf_response(code=404,
message='person with kf_id \'{}\' not found'.
format(kf_id))Since the kf_response method already returns the tuple: (result dict, status code), we can just return the result of kf_response.
znatty22
reviewed
Jan 17, 2018
dataservice/api/person/resources.py
Outdated
| from dataservice.api.person.serializers import (person_model, | ||
| response_model) | ||
| from dataservice.api.person.serializers import ( | ||
| person_model, |
There was a problem hiding this comment.
person_model looks like its no longer used in this file
dankolbman
force-pushed
the
model-formatting
branch
from
832d757 to
886193e
Compare
znatty22
requested changes
Jan 17, 2018
dankolbman
changed the title
dankolbman
force-pushed
the
model-formatting
branch
2 times, most recently
from
0e5d0f4 to
110754d
Compare
znatty22
previously approved these changes
Jan 18, 2018
dankolbman
force-pushed
the
model-formatting
branch
from
110754d to
79796e9
Compare
dankolbman
force-pushed
the
model-formatting
branch
from
79796e9 to
c1e82c3
Compare
Merged
alubneuski
pushed a commit
that referenced
this pull request
Oct 11, 2024
♻️ Formatting responses and abstracting out some of the models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draws out some of the base models and establishes the common response formats.
TODO:
General test to test that all endpoints match this format