Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix circleci #37

Merged
merged 2 commits into from
Jan 18, 2018
Merged

🐛 Fix circleci #37

merged 2 commits into from
Jan 18, 2018

Conversation

dankolbman
Copy link
Contributor

CircleCI was always passing because flask test always returned 0 exit codes. Oops.

@dankolbman dankolbman added the bug Something isn't working label Jan 18, 2018
@dankolbman dankolbman self-assigned this Jan 18, 2018
znatty22
znatty22 previously approved these changes Jan 18, 2018
View reviewed changes
Copy link
Member

@znatty22 znatty22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dankolbman dankolbman merged commit e1f49a7 into master Jan 18, 2018
@dankolbman dankolbman deleted the fix-circleci branch January 18, 2018 17:54
@dankolbman dankolbman mentioned this pull request Apr 2, 2018
Merged
alubneuski pushed a commit that referenced this pull request Oct 11, 2024
@dankolbman
Merge pull request #37 from kids-first/fix-circleci
8b06135 
🐛 Fix circleci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parimalak parimalak parimalak approved these changes

@znatty22 znatty22 znatty22 left review comments

Assignees

@dankolbman dankolbman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dankolbman @znatty22 @parimalak