🐛 Update/fix Base class in models.py #38
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change Base to inherit only the model mixins (Base should not inherit db.Model) If Base inherits db.Model then this is saying that Base is a db.Model/a sqlalchemy declarative base. sqlalchemy will think that we are trying to do single table inheritance, which I don't believe we are. We just want a class representing the common columns across entities. Even if we were trying to do single table inheritance, then we need to add additional code to all child classes of Base to instruct sqlalchemy on how to handle two entity models with the same column names. See link for more details: http://docs.sqlalchemy.org/en/latest/orm/extensions/declarative/inheritance.html
parimalak
approved these changes
Jan 18, 2018
Merged
alubneuski
pushed a commit
that referenced
this pull request
Oct 11, 2024
🐛 Update/fix Base class in models.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Base to inherit only the model mixins (Base should not inherit db.Model)
If Base inherits db.Model then this is saying that Base is a db.Model/a
sqlalchemy declarative base. sqlalchemy will think that we are trying to
do single table inheritance, which I don't believe we are. We just want
a class representing the common columns across entities.
Even if we were trying to do single table inheritance, then we need to add
additional code to all child classes of Base to instruct sqlalchemy on
how to handle two entity models with the same column names.
See link for more details:
http://docs.sqlalchemy.org/en/latest/orm/extensions/declarative/inheritance.html