Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Rename Person to Participant in all relevant files #60

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

znatty22
Copy link
Member

No description provided.

@dankolbman
Copy link
Contributor

Should probably go back and redo commit with git mv (I don't think it can be patched?). Otherwise it's going to be a lot of fun rebasing our other branches :p

@znatty22 znatty22 closed this Jan 21, 2018
@znatty22 znatty22 force-pushed the refactor/person-to-participant branch from ecf6266 to b721c0c Compare January 21, 2018 14:19
@znatty22 znatty22 reopened this Jan 21, 2018
@znatty22 znatty22 force-pushed the refactor/person-to-participant branch from 5e5bfbf to 156b6f8 Compare January 21, 2018 15:09
@znatty22
Copy link
Member Author

So I tried git mv, but the git log looks the same. I think git actually automatically did the rename in my first attempt as well so there's no difference. Let me know if if you think there's a better approach?

Copy link
Contributor

@dankolbman dankolbman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still rebases fine, and we don't have anything to rebase that makes changes on the participant/person, so should be ok..

I think the proper way to do it is to commit the move and modifications in separate commits, but it's functionally equivalent.

@znatty22 znatty22 added the refactor Something needs to be done better label Jan 22, 2018
@znatty22 znatty22 merged commit bccf1d0 into master Jan 22, 2018
@znatty22 znatty22 deleted the refactor/person-to-participant branch January 22, 2018 20:01
@dankolbman dankolbman mentioned this pull request Apr 2, 2018
alubneuski pushed a commit that referenced this pull request Oct 11, 2024
♻️ Rename Person to Participant in all relevant files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Something needs to be done better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants