♻️ Refactor pg exceptions to flask error handler #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankolbman
force-pushed
the
postgres-errors
branch
from
120e40d to
94e3b96
Compare
dankolbman
changed the title
dankolbman
force-pushed
the
postgres-errors
branch
2 times, most recently
from
854bd25 to
753813c
Compare
znatty22
reviewed
Feb 2, 2018
dataservice/api/errors.py
Outdated
| 'Cannot {0} {1}, {2} already has a {1}' | ||
|
|
||
| DEFAULT_INVALID_INPUT_TEMPLATE = 'Client error: invalid {} provided' | ||
| FOREIGN_KEY_RE = re.compile(r'DETAIL:.*\((?P<kf_id>\w{8})\)' + |
There was a problem hiding this comment.
I think you may want to change this regex to be a bit more general (i.e don't limit to 8 chars, etc). Right now requests like
POST /demographics
{
"participant_id": ""
}
result in the default error message of error saving changes.
|
|
||
|
|
||
| def http_error(e): | ||
| """ Handles all HTTPExceptions """ | ||
| return ErrorSchema().jsonify(e), e.code | ||
|
|
||
|
|
||
| def handle_integrity_error(**kwargs): | ||
| def integrity_error(e): | ||
| """ |
| message = '{} "{}" does not exist'.format(m.group('table'), | ||
| m.group('kf_id')) | ||
|
|
||
| m = UNIQUE_RE.match(error) |
There was a problem hiding this comment.
Hmm the error message is a little confusing here. If someone tries to create a demographic for a participant that already has a demographic the error message is: participant "144WDN78" already exists
Can we make it something like: participant "144WDN78" already has demographic.
You could get the primary entity (demographic) by parsing e.statement (i.e. INSERT INTO demographic, UPDATE demographic etc).
dankolbman
force-pushed
the
postgres-errors
branch
2 times, most recently
from
83392fa to
ebb8e7a
Compare
dankolbman
force-pushed
the
postgres-errors
branch
from
ebb8e7a to
906a80a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old error handling for sqlite breaks when we change backends. This implements a general flask exception handler for
IntegrityErrorthat processes error responses from postgres.