🐛 Stringify before checking for printable chars #483
Merged
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
=======================================
Coverage 92.27% 92.27%
=======================================
Files 69 69
Lines 3273 3276 +3
=======================================
+ Hits 3020 3023 +3
Misses 253 253
Continue to review full report at Codecov.
|
dankolbman
added a commit
that referenced
this pull request
Sep 24, 2020
## Release 1.14.5 ### Summary - Emojis: 🐛 x1 - Categories: Fixes x1 ### New features and changes - [#483](#483) - 🐛 Stringify before checking for printable chars - [eb43ec7](eb43ec7) by [dankolbman](https://github.com/dankolbman)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are column names that are non string, like numbers, the current method will fail to parse because
isprintable()is a string method.