🐛 Fix API logging #768
Merged
🐛 Fix API logging #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znatty22
force-pushed
the
fix-api-logging
branch
from
69edd2e
to
63cac5f
Compare
Codecov Report
@@ Coverage Diff @@
## master #768 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 172 172
Lines 7479 7480 +1
=======================================
+ Hits 7106 7107 +1
Misses 373 373
Continue to review full report at Codecov.
|
gsantia
approved these changes
Sep 30, 2021
Sets the creator logger to INFO level so that messages will be processed by the handlers Remove redundant logging configurations from the settings If any module needs to do something different than the creator logger, add it as an additional block (e.g. genomic_data_loader.py) Log messages from the creator logger were being ignored by it's handlers since the handlers are set to process messages at INFO level or higher while the creator logger was set to the default log level of WARNING
znatty22
force-pushed
the
fix-api-logging
branch
from
63cac5f
to
dca8ac0
Compare
gsantia
approved these changes
Sep 30, 2021
znatty22
added a commit
that referenced
this pull request
Sep 30, 2021
## Release 1.19.7 ### Summary - Emojis: 🐛 x2, ♻️ x1 - Categories: Fixes x2, Other Changes x1 ### New features and changes - [#768](#768) - 🐛 Fix API logging - [b07e9b9](b07e9b9) by [znatty22](https://github.com/znatty22) - [#767](#767) - 🐛 Fix writing of job logs in local development - [d078b8e](d078b8e) by [znatty22](https://github.com/znatty22) - [#763](#763) - ♻️ Omit Content-Length header in download validation report - [f61c0e8](f61c0e8) by [znatty22](https://github.com/znatty22)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #760
Tested locally and in deployed dev. Now we can see log messages from all loggers under the parent creator logger in the console and the TaskLogger's stream