Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix slack notifications #772

Merged
merged 3 commits into from
Oct 1, 2021
Merged

🐛 Fix slack notifications #772

merged 3 commits into from
Oct 1, 2021

Conversation

znatty22
Copy link
Member

Closes #771

@znatty22 znatty22 self-assigned this Sep 30, 2021
@znatty22 znatty22 added the bug Something isn't working label Sep 30, 2021
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #772 (2c6c73d) into master (9699242) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
+ Coverage   95.56%   95.65%   +0.09%     
==========================================
  Files         172      172              
  Lines        7434     7433       -1     
==========================================
+ Hits         7104     7110       +6     
+ Misses        330      323       -7     
Impacted Files Coverage Δ
creator/slack.py 90.07% <100.00%> (+5.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b445e8...2c6c73d. Read the comment docs.

@znatty22 znatty22 force-pushed the fix-slack-notifications branch from 0b6091d to 2308500 Compare September 30, 2021 21:29
@znatty22 znatty22 marked this pull request as ready for review September 30, 2021 21:31
@gsantia
Copy link
Contributor

gsantia commented Sep 30, 2021

codecov doesn't like it

@znatty22 znatty22 marked this pull request as draft September 30, 2021 21:33
@znatty22 znatty22 force-pushed the fix-slack-notifications branch from 2308500 to 39a6acd Compare September 30, 2021 21:38
@znatty22 znatty22 marked this pull request as ready for review September 30, 2021 21:39
@znatty22 znatty22 force-pushed the fix-slack-notifications branch from 39a6acd to c717ed2 Compare September 30, 2021 21:57
@znatty22 znatty22 force-pushed the fix-slack-notifications branch from c717ed2 to 2c6c73d Compare September 30, 2021 22:48
@znatty22 znatty22 merged commit 4d95618 into master Oct 1, 2021
@znatty22 znatty22 deleted the fix-slack-notifications branch October 1, 2021 14:45
znatty22 added a commit that referenced this pull request Oct 1, 2021
## Release 1.19.8

### Summary

- Emojis: 🐛 x1, 🔥 x1
- Categories: Removals x1, Fixes x1

### New features and changes

- [#772](#772) - 🐛 Fix slack notifications - [4d95618](4d95618) by [znatty22](https://github.com/znatty22)
- [#774](#774) - 🔥 Remove sync job with old release coordinator - [7b445e8](7b445e8) by [znatty22](https://github.com/znatty22)
@znatty22 znatty22 mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken slack notifications
2 participants