🐛 File event tests should be deterministic #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znatty22
force-pushed
the
fix-file-event-tests
branch
from
de89df4
to
f92db64
Compare
gsantia
approved these changes
Nov 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
=======================================
Coverage 95.70% 95.70%
=======================================
Files 172 172
Lines 7474 7474
=======================================
Hits 7153 7153
Misses 321 321 Continue to review full report at Codecov.
|
gsantia
added a commit
that referenced
this pull request
Nov 2, 2021
## Release 1.20.0 ### Summary - Emojis: 🐛 x3, ♻️ x3, 📌 x1, ✨ x2 - Categories: Additions x2, Fixes x3, Ops x1, Other Changes x3 ### New features and changes - [#797](#797) - 🐛 File event tests should be deterministic - [e809638](e809638) by [znatty22](https://github.com/znatty22) - [#791](#791) - 🐛 Use proper bucket arn in bucket inventory configuration - [9045543](9045543) by [znatty22](https://github.com/znatty22) - [#794](#794) - ♻️ Only save study attrs from Dataservice that exist on Study - [3c09f5e](3c09f5e) by [znatty22](https://github.com/znatty22) - [#793](#793) - 📌 Pin docutils<0.18 - [75a989a](75a989a) by [znatty22](https://github.com/znatty22) - [#787](#787) - ♻️ Refactor naming of single template package names - [96c6c41](96c6c41) by [gsantia](https://github.com/gsantia) - [#785](#785) - ♻️ Refactor update study and file log message to which fields are updated - [93a79b1](93a79b1) by [XuTheBunny](https://github.com/XuTheBunny) - [#778](#778) - ✨ Add template download events - [b6498ab](b6498ab) by [gsantia](https://github.com/gsantia) - [#776](#776) - ✨ Capture time of release termination - [22322e8](22322e8) by [gsantia](https://github.com/gsantia) - [#783](#783) - 🐛 Fix release logging messages - [931e9d9](931e9d9) by [gsantia](https://github.com/gsantia)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some file event tests randomly fail bc they depend on a user that is not deterministic