-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky tests caused by parallel jobs log parsing #60
Comments
TWiStErRob
added a commit
to TWiStErRob/act-js
that referenced
this issue
Dec 8, 2023
TWiStErRob
added a commit
to TWiStErRob/act-js
that referenced
this issue
Dec 8, 2023
shubhbapna
pushed a commit
that referenced
this issue
Dec 27, 2023
Can you please release this? |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If one job starts a group, and another logs while that group is open, then the parser crashes with:
this.groupMatrix[stepOutputMatcherResult[1]] === []
, thereforelength
is 0, and...[-1] === undefined
.To Reproduce
act.log
:Expected behavior
"Just works".
Logs
Distilled real log focused on the issue
Additional context
Looking at output-parser.js, as far as I see
.isPartOfGroup
is handled on the parser level, but it should per-job.The text was updated successfully, but these errors were encountered: