-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHPAM-4915] Allow to configure default abort parent behaviour #2401
base: main
Are you sure you want to change the base?
Conversation
jbpm-flow/src/main/java/org/jbpm/workflow/core/node/SubProcessNode.java
Outdated
Show resolved
Hide resolved
jbpm-flow/src/main/java/org/jbpm/workflow/core/node/SubProcessNode.java
Outdated
Show resolved
Hide resolved
de37a77
to
5c9f51d
Compare
ok to test |
jenkins do fdb |
5c9f51d
to
482bc10
Compare
Quality Gate passedIssues Measures |
jenkins do fdb |
@elguardian can you add a review here? Just to explain the scenario. A subprocess calling a Rest WIH (in sync thread of start node) where the external rest service is down, will abort the subprocess and abort the parent if "abort parent is set". As I show different behaviour on this for RHPAM 7.3 with RHPAM 7.13.2, so comparing jbpm-flow/src/main/java/org/jbpm/workflow/instance/node/SubProcessNodeInstance.java this could be the relevant change: 50a61c9018#diff-c08f01bff8c2ced14acdfbcbe934979871b5ee6edb08e7f59de7f4f4ed073566L228-R237 we are now handling the error on start of process too: https://issues.redhat.com/browse/RHPAM-2782 Since RHPAM 7.7.1 I think, so before that change any error starting a subprocess is not handled and just goes up "abort parent" unset just has same effect, ignore and send the exception up For migrations before 7.7.1, this change might be allow easier migrations, while users are aware they need to modify their subprocess calls |
@albfan it does not have the same effect as boundary events will stop working more likely. I would suggest to create some sort of flag... legacybehaviour |
Will test a bit and let you know |
Behaviour after RHPAM 7.5 was modified. Any aborted subprocess will abort its parent.
This property allows to get the old behaviour so migrations from versions previous to RHPAM 7.5 behaves the same in recent RHPAM versions