Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.67.x-blue][JBPM-10242] Allow the possibility of disabling linear search for rem… #2446

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

gmunozfe
Copy link
Member

@gmunozfe gmunozfe commented Oct 9, 2024

…oveJob and getTimerByName operations (#2441)

  • Try to cancel timer always, and only search if timer cancellation fails

  • Skipping list search completely if !searchIfFailed

  • [JBPM-10242] Always skipping linear search

Unless explicilty stated with property org.jbpm.ejb.timer.linear.search

  • [JBPM-10242] Disable linear search on condition

Setting org.jbpm.ejb.timer.disable.linear.search and org.jbpm.ejb.timer.disable.linear.remove to true

  • [JBPM-10242] Fixing integration tests

Thank you for submitting this pull request

JIRA: (please edit the JIRA link if it exists)

link

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

  • paste the link(s) from GitHub here
  • link 2
  • link 3 etc.
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@gmunozfe
Copy link
Member Author

gmunozfe commented Oct 9, 2024

jenkins test this

@gmunozfe
Copy link
Member Author

gmunozfe commented Oct 9, 2024

jenkins do fdb

@gmunozfe gmunozfe changed the title [JBPM-10242] Allow the possibility of disabling linear search for rem… [7.67.x-blue][JBPM-10242] Allow the possibility of disabling linear search for rem… Oct 9, 2024
@gmunozfe gmunozfe force-pushed the 7.67.x-blue_timer_cancel_path branch 2 times, most recently from 8b7ddc4 to 54ce644 Compare October 10, 2024 00:03
gmunozfe and others added 2 commits October 10, 2024 02:07
…oveJob and getTimerByName operations (kiegroup#2441)

* Try to cancel timer always, and only search if timer cancellation fails

* Skipping list search completely if !searchIfFailed

* [JBPM-10242] Always skipping linear search

Unless explicilty stated with property org.jbpm.ejb.timer.linear.search

* [JBPM-10242] Disable linear search on condition

Setting org.jbpm.ejb.timer.disable.linear.search and
org.jbpm.ejb.timer.disable.linear.remove to true

* [JBPM-10242] Fixing integration tests

---------

Co-authored-by: krisv <kris.verlaenen@gmail.com>
@gmunozfe gmunozfe force-pushed the 7.67.x-blue_timer_cancel_path branch from 54ce644 to 2750645 Compare October 10, 2024 00:08
@gmunozfe
Copy link
Member Author

jenkins do fdb

@gmunozfe
Copy link
Member Author

Failing tests in fdb seem unrelated (timeouts), so this is ready to be merged @fjtirado

org.kie.server.client.LoadBalancerClientTest.testDefaultLoadBalancerNoServersAvailable
No available endpoints found

org.kie.server.springboot.samples.KafkaEmitterHappyPathTest.testEmitterRecordTooLargeException
test timed out after 30000 milliseconds

@fjtirado fjtirado merged commit 978e078 into kiegroup:7.67.x-blue Oct 10, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants