Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate to undici MockClient #79

Closed
wants to merge 7 commits into from
Closed

feat: Migrate to undici MockClient #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
74fa0bc
feat: Migrate to undici MockClient
oliversalzburg Oct 27, 2023
e94e037
Fix unused import
oliversalzburg Nov 14, 2023
99191d7
Use strict equal comparison
oliversalzburg Nov 14, 2023
02fd08a
Allow user to override `content-type`
oliversalzburg Nov 14, 2023
1a6df34
Fix missing header matching
oliversalzburg Nov 14, 2023
1b4d0a9
Use `@mg` import
oliversalzburg Nov 14, 2023
f489538
Also test on Node18
oliversalzburg Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to support node 18 as well, so probably change it to matrix and test for both? Same for all the other workflow files

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this is the publish job. The matrix is already in pull_request 😄 I'll add 18 there.

registry-url: https://registry.npmjs.org/

- name: Install packages
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
tests:
strategy:
matrix:
node-version: [16.x]
node-version: [18,20]
os: [ubuntu-latest]
fail-fast: false
runs-on: ${{ matrix.os }}
Expand All @@ -36,7 +36,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 20

- name: Install packages
run: npm ci
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Setup sonarqube
uses: warchant/setup-sonar-scanner@v3
uses: warchant/setup-sonar-scanner@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20
- run: npm ci
- run: npm run test:report
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20
cache: npm
- run: npm install @octokit/openapi-types-ghec -D
- run: npm ci
Expand Down
5 changes: 1 addition & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,7 @@ Using this library along with [kiegroup/act-js](https://github.com/kiegroup/act-

## Moctokit

> [!WARNING]
> Moctokit is currently not compatible with Node 18's native `fetch` implementation since it uses `nock` under the hood See [nock/nock#2397](https://github.com/nock/nock/issues/2397)

Allows you to mock [octokit](https://octokit.github.io/rest.js/v19) using an octokit like interface.
Allows you to mock [octokit](https://octokit.github.io/rest.js/v20) using an octokit like interface.

Example

Expand Down
Loading