Add tslint-airbnb-config (#40)

* Install tslint-config-airbnb * Remove tslint exclusion, add --project argument * Remove extra parameters * More script friendly * IDEA fixes * Ignore import names for now * Rest of comma and semi fixes * Manual fixes * Sort rules * Allow Array type parameters palantir/tslint#2946 (comment) * Allow pascal case variable names because of SFCs Co-Authored-By: yurloc <jiri.locker@gmail.com> * Allow pascal case because of components declared as fuctions
kiegroup · Dec 11, 2018 · 4465be8 · 4465be8
1 parent 6aff535
commit 4465be8
Show file tree

Hide file tree

Showing 18 changed files with 255 additions and 67 deletions.
diff --git a/optaweb-tsp-ui/package-lock.json b/optaweb-tsp-ui/package-lock.json
diff --git a/optaweb-tsp-ui/package.json b/optaweb-tsp-ui/package.json
@@ -19,7 +19,7 @@
     "start": "react-scripts-ts start",
     "build": "react-scripts-ts build",
     "test": "react-scripts-ts test --env=jsdom",
-    "lint": "./node_modules/tslint/bin/tslint -c tslint.json 'src/**/*.{ts,tsx}' -e 'src/@types/**'",
+    "lint": "./node_modules/tslint/bin/tslint -p tsconfig.json --force",
     "lint:fix": "npm run lint -- --fix",
     "eject": "react-scripts-ts eject"
   },
@@ -39,6 +39,7 @@
     "enzyme-adapter-react-16": "^1.7.0",
     "react-test-renderer": "^16.6.3",
     "redux-devtools-extension": "^2.13.7",
+    "tslint-config-airbnb": "^5.11.1",
     "typescript": "^3.1.6"
   },
   "browserslist": [

diff --git a/optaweb-tsp-ui/src/@types/react-styles.d.ts b/optaweb-tsp-ui/src/@types/react-styles.d.ts
@@ -1,25 +1,43 @@
+/*
+ * Copyright 2018 Red Hat, Inc. and/or its affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 
+// tslint:disable:interface-name
+// tslint:disable:variable-name
 declare module '@patternfly/react-styles' {
   export interface StyleDeclarationStatic {
     __className: string;
+
     __inject(): void;
   }
 
   export function isValidStyleDeclaration(
-    obj: any
+    obj: any,
   ): obj is StyleDeclarationStatic;
 
   export function createStyleDeclaration(
     className: string,
-    rawCss: string
+    rawCss: string,
   ): StyleDeclarationStatic;
 
   export function isModifier(className: string): boolean;
 
   export function getModifier(
     styleObject: any,
     modifier: string,
-    defaultModifer?: StyleDeclarationStatic | string
+    defaultModifer?: StyleDeclarationStatic | string,
   ): StyleDeclarationStatic | string;
 
   export function formatClassName(className: string): string;
@@ -32,8 +50,9 @@ declare module '@patternfly/react-styles' {
 
   export interface StyleSheetStatic {
     parse(cssString: string): StyleSheetValueStatic;
+
     create<T extends Record<keyof T, any>>(
-      styles: T
+      styles: T,
     ): Record<keyof T, string>;
   }
 

diff --git a/optaweb-tsp-ui/src/components/ConnectionError.tsx b/optaweb-tsp-ui/src/components/ConnectionError.tsx
@@ -16,11 +16,11 @@
 
 import { Modal, Text, TextContent, TextVariants } from '@patternfly/react-core';
 import * as React from 'react';
-import { ReactNode } from 'react';
+
 export interface IConnectionErrorProps {
   title: string;
   message: string;
-  icon?: ReactNode;
+  icon?: React.ReactNode;
   help?: string;
 }
 

diff --git a/optaweb-tsp-ui/src/components/Location.test.tsx b/optaweb-tsp-ui/src/components/Location.test.tsx
@@ -31,7 +31,6 @@ describe('Location Component', () => {
     expect(location).toMatchSnapshot();
     location.find('Grid').simulate('mouseEnter');
     location.find('Button').simulate('click');
-
 
     expect(props.removeHandler).toHaveBeenCalledTimes(1);
   });

diff --git a/optaweb-tsp-ui/src/components/LocationList.test.tsx b/optaweb-tsp-ui/src/components/LocationList.test.tsx
@@ -18,6 +18,7 @@ import { shallow } from 'enzyme';
 import * as React from 'react';
 import * as types from '../store/tsp/types';
 import LocationList from './LocationList';
+
 describe('Location List Component', () => {
   it('should render correctly with no routes', () => {
     const props = {
@@ -28,8 +29,7 @@ describe('Location List Component', () => {
       removeHandler: jest.fn(),
       route: [],
       selectHandler: jest.fn(),
-      ws: types.WS_CONNECTION_STATE.OPEN
-
+      ws: types.WS_CONNECTION_STATE.OPEN,
     };
     expect.assertions(2);
     const locationList = shallow(<LocationList {...props} />);
@@ -65,7 +65,7 @@ describe('Location List Component', () => {
         },
       ],
       selectHandler: jest.fn(),
-      ws: types.WS_CONNECTION_STATE.OPEN
+      ws: types.WS_CONNECTION_STATE.OPEN,
     };
     expect.assertions(2);
     const locationList = shallow(<LocationList {...props} />);

diff --git a/optaweb-tsp-ui/src/components/LocationList.tsx b/optaweb-tsp-ui/src/components/LocationList.tsx
@@ -87,7 +87,7 @@ const renderLocationList = ({
 };
 
 const LocationList: React.SFC<ILocationListProps> = (
-  props: ILocationListProps
+  props: ILocationListProps,
 ) => {
   return (
     <div

diff --git a/optaweb-tsp-ui/src/components/TravelingSalesmanProblem.tsx b/optaweb-tsp-ui/src/components/TravelingSalesmanProblem.tsx
@@ -44,6 +44,7 @@ export default class TravelingSalesmanProblem extends React.Component<
       segments: [],
     },
   };
+
   constructor(props: ITravelingSalesmanProblemProps) {
     super(props);
 
@@ -71,6 +72,7 @@ export default class TravelingSalesmanProblem extends React.Component<
       this.setState({ maxDistance: intDistance });
     }
   }
+
   render() {
     const { center, zoom, selectedId, maxDistance } = this.state;
     const {

diff --git a/optaweb-tsp-ui/src/components/TspMap.tsx b/optaweb-tsp-ui/src/components/TspMap.tsx
@@ -22,7 +22,7 @@ import {
   Polyline,
   TileLayer,
   Tooltip,
-  ZoomControl
+  ZoomControl,
 } from 'react-leaflet';
 import { ILatLng, ITSPRouteWithSegments } from '../store/tsp';
 
@@ -42,7 +42,7 @@ const TspMap: React.SFC<ITspMapProps> = ({
   segments,
   domicileId,
   clickHandler,
-  removeHandler
+  removeHandler,
 }) => {
   const homeIcon = L.icon({
     iconAnchor: [12, 12],
@@ -51,7 +51,7 @@ const TspMap: React.SFC<ITspMapProps> = ({
     popupAnchor: [0, -10],
     shadowAnchor: [16, 2],
     shadowSize: [50, 16],
-    shadowUrl: 'if_big_house-home_2222740_shadow.png'
+    shadowUrl: 'if_big_house-home_2222740_shadow.png',
   });
   const defaultIcon = new L.Icon.Default();
   return (
@@ -63,7 +63,9 @@ const TspMap: React.SFC<ITspMapProps> = ({
       zoomControl={false} // hide the default zoom control which is on top left
     >
       <TileLayer
-        attribution={'&amp;copy <a href=\"http://osm.org/copyright\">OpenStreetMap</a> contributors'}
+        attribution={
+          '&amp;copy <a href=\"http://osm.org/copyright\">OpenStreetMap</a> contributors'
+        }
         url="https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png"
       />
       <ZoomControl position="topright" />
@@ -80,9 +82,7 @@ const TspMap: React.SFC<ITspMapProps> = ({
             key={location.id + (location.id === selectedId ? 'T' : 't')}
             permanent={location.id === selectedId}
           >
-            {`Location ${location.id} [Lat=${location.lat}, Lng=${
-              location.lng
-            }]`}
+            {`Location ${location.id} [Lat=${location.lat}, Lng=${location.lng}]`}
           </Tooltip>
         </Marker>
       ))}
@@ -91,6 +91,4 @@ const TspMap: React.SFC<ITspMapProps> = ({
   );
 };
 
-
-
 export default TspMap;