Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Unify build output and classpath configurations #215

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HannesWell
Copy link
Contributor

Avoid using PDE's 'requiredPlugins'-container together with M2E's 'MAVEN2_CLASSPATH_CONTAINER'-container. When using both at the same time, one only ensures that Maven and PDE dependencies combined work, which is never a real use-case.

Also fix multiple build-configuration related warnings.

Avoid using PDE's 'requiredPlugins'-container together with M2E's
'MAVEN2_CLASSPATH_CONTAINER'-container. When using both at the same
time, one only ensures that Maven and PDE dependencies combined work,
which is never a real use-case.

Also fix multiple build-configuration related warnings.
Copy link
Member

@NiklasRentzCAU NiklasRentzCAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not quite sure about some of these changes, let me elaborate the thought behind this current setup:
KLighD is historically developed in Eclipse and provides Eclipse Plug-Ins, which is why most build on Plug-In dependencies in the Eclipse configuration. However, KLighD is also available as an Eclipse-less standalone/language server variant, which does not use any of the Plug-In dependencies, but Maven dependencies via their pom.xml. The dependencies are not entirely duplicated but mostly put into poms for the setup/ls containing all further downstream dependencies.

Now because of this setup, most projects are also Maven projects so that Eclipse handles them correctly. Eclipse then does some automatic changes to the code, including for example the change of using target/classes as the default output instead of bin which I would therefore like to keep that way.
The PDE/M2E containers seem like an error to me as well and should only have one. piccolo.freehep should probably only have the PDE container, while the setup and standalone should only have the Maven container; they are only ever executed as plain Java applications without PDE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants