Improve wording for ctrlp_working_path_mode #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make README screenshot narrower so it fits on the GitHub project home page The current screenshot as displayed on https://github.com/kien/ctrlp.vim is squished to fit within 722px, introducing aliasing and making the screenshot hard to read. This updated image is 720px, so it will fit, and provide a better first impression of ctrlp.vim to people visiting the project page. I produced this screenshot in Photoshop by effectively deleting some of the empty space in the middle. The window in the image might not be a realistically-sized one – its width might not be a multiple of the character cell width – but nobody will notice.
|
👍 |
|
Much better, now I get it. Thanks! Two further clarifications might help...
|
In Windows, some users set the Cygwin shell as their Vim shell, consider this before rewriting `cd` calls. Checking if `shellcmdflag` contains a backslash should catch all true windows shells. You can also check if &shell contains `sh`, but this seems more robust.
Added support for custom ancestors: g:ctrlp_custom_ancestors.
|
Moved to ctrlpvim#12 |
Make README screenshot narrower to fit
This creates the ability to add custom highlighting to CtrlP signs/marks if someone wishes to change them. It links back to the Search group to maintain backwards compatibility.
Added CtrlPMark highlight group
Translate documentation to Chinese
Check shell in Windows before assuming cmd.exe
Drop migemo
Update URLs in README to point to new repo
Support ordered processing of multiple g:ctrlp_working_path_mode specifications Clarify g:ctrlp_working_path_mode semantics in readme.md
Add ability to specify a custom ignore function, instead of just patterns
Support ctrlp_custom_ignore as function ref
Update the README to include an example.
Remove custom_ancestors since root_markers does the same thing.
…working_path_mode Conflicts: readme.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #397, I've also found the description of the search path flags a bit confusing, I had to resort to the code to understand it. Hopefully this will help.