Skip to content

Commit

Permalink
Search is not mandatory in ClayManagementToolbar | Fixes liferay#543
Browse files Browse the repository at this point in the history
  • Loading branch information
Carlos Lancha authored and Kien Do committed Feb 21, 2018
1 parent 36d6a11 commit 3ea111e
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 22 deletions.
17 changes: 13 additions & 4 deletions packages/clay-management-toolbar/src/ClayManagementToolbar.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class ClayManagementToolbar extends Component {
* @private
*/
handleCloseMobileSearchClick_() {
this.showSearch_ = false;
this.showSearchMobile_ = false;
}

/**
Expand Down Expand Up @@ -88,7 +88,7 @@ class ClayManagementToolbar extends Component {
* @private
*/
handleOpenMobileSearchClick_() {
this.showSearch_ = true;
this.showSearchMobile_ = true;
}

/**
Expand Down Expand Up @@ -274,14 +274,23 @@ ClayManagementToolbar.STATE = {
selectedItems: Config.number(),

/**
* Flag to indicate if search should be shown in or not. This is for the
* Flag to indicate if search should be shown or not.
* @instance
* @memberof ClayManagementToolbar
* @type {?bool}
* @default true
*/
showSearch: Config.bool().value(true),

/**
* Flag to indicate if search should be shown or not. This is for the
* hide/show interaction in small devices.
* @instance
* @memberof ClayManagementToolbar
* @type {?bool}
* @default false
*/
showSearch_: Config.bool()
showSearchMobile_: Config.bool()
.internal()
.value(false),

Expand Down
41 changes: 23 additions & 18 deletions packages/clay-management-toolbar/src/ClayManagementToolbar.soy
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@
{@param? searchInputName: string}
{@param? selectable: bool}
{@param? selectedItems: number}
{@param? showSearch_: bool}
{@param? showSearch: bool}
{@param? showSearchMobile_: bool}
{@param? sortingOrder: string}
{@param? totalItems: number}
{@param? viewTypes: list<[
Expand Down Expand Up @@ -102,7 +103,8 @@
{param searchFormName: $searchFormName /}
{param searchInputName: $searchInputName /}
{param selectable: $selectable /}
{param showSearch_: $showSearch_ /}
{param showSearch: $showSearch != false /}
{param showSearchMobile_: $showSearchMobile_ /}
{param sortingOrder: $sortingOrder /}
{param spritemap: $spritemap /}
{param viewTypes: $viewTypes /}
Expand Down Expand Up @@ -259,7 +261,8 @@
{@param? searchFormName: string}
{@param? searchInputName: string}
{@param? selectable: bool}
{@param? showSearch_: bool}
{@param? showSearch: bool}
{@param? showSearchMobile_: bool}
{@param? sortingOrder: string}
{@param? viewTypes: list<[
active: bool,
Expand All @@ -281,7 +284,7 @@
{/let}

<nav {$navAttributes}>
{let $onlySearch: not $creationMenu and not $selectable and not $filterItems and not $sortingOrder and not $viewTypes /}
{let $onlySearch: $showSearch and not $creationMenu and not $selectable and not $filterItems and not $sortingOrder and not $viewTypes /}

{let $containerClasses kind="text"}
{if $onlySearch}
Expand Down Expand Up @@ -350,27 +353,29 @@
navbar-form navbar-form-autofit
{if not $onlySearch}
{sp}navbar-overlay navbar-overlay-sm-down
{if $showSearch_}
{if $showSearchMobile_}
{sp}show
{/if}
{/if}
{/let}

<div class="{$searchClasses}">
{delcall ClayManagementToolbar.SearchForm variant="$contentRenderer"}
{param disabled: $disabled /}
{param handleCloseMobileSearchClick_: $handleCloseMobileSearchClick_ /}
{param handleSearchSearchClick_: $handleSearchSearchClick_ /}
{param onlySearch: $onlySearch /}
{param searchActionURL: $searchActionURL /}
{param searchFormName: $searchFormName /}
{param searchInputName: $searchInputName /}
{param spritemap: $spritemap /}
{/delcall}
</div>
{if $showSearch}
<div class="{$searchClasses}">
{delcall ClayManagementToolbar.SearchForm variant="$contentRenderer"}
{param disabled: $disabled /}
{param handleCloseMobileSearchClick_: $handleCloseMobileSearchClick_ /}
{param handleSearchSearchClick_: $handleSearchSearchClick_ /}
{param onlySearch: $onlySearch /}
{param searchActionURL: $searchActionURL /}
{param searchFormName: $searchFormName /}
{param searchInputName: $searchInputName /}
{param spritemap: $spritemap /}
{/delcall}
</div>
{/if}

<ul class="navbar-nav">
{if not $onlySearch}
{if $showSearch and not $onlySearch}
<li class="nav-item navbar-breakpoint-d-none">
{call ClayButton.render}
{param disabled: $disabled /}
Expand Down

0 comments on commit 3ea111e

Please sign in to comment.