Support setting http.Server properties through config. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some http.Server properties that are useful to be able to set as part of the configuration of the server. This allows you to put the properties on the config object passed to the SimpleWeb constructor to set the corresponding keys on the Server instance.
One reason this can be useful is if your application is behind a load balancer: your app's keepAliveTimeout should be greater than your load balancer's idle timeout.
Another reason this is useful is to work around bug nodejs/node#27363 (In short, make your headersTimeout greater than your keepAliveTimeout.)