Fix Issue #1181 - dismissPopover does not work on iOS 14
#1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harleyjcooper
approved these changes
Sep 16, 2020
Classes/KIFUITestActor.m
Outdated
| @@ -1164,7 +1168,7 @@ - (void)pullToRefreshAccessibilityElement:(UIAccessibilityElement *)element inVi | |||
| // Can handle only the touchable space. | |||
| CGRect elementFrame = [viewToSwipe convertRect:viewToSwipe.bounds toView:[UIApplication sharedApplication].keyWindow.rootViewController.view]; | |||
| CGPoint swipeStart = CGPointCenteredInRect(elementFrame); | |||
| CGPoint swipeDisplacement = CGPointMake(CGRectGetMidX(elementFrame), CGRectGetMaxY(elementFrame)); | |||
| CGPoint swipeDisplacement = CGPointMake(CGRectGetMidX(elementFrame) - swipeStart.x, CGRectGetMaxY(elementFrame) - swipeStart.y); | |||
There was a problem hiding this comment.
What change led to this bit? Why has the displacement changed?
There was a problem hiding this comment.
Oops didn't mean to change this.
The reason why i even put this in here at all was when I put in the visualizer i noticed the the pull to refresh went diagonally this fixes that. Not an issue so going to leave as is for now but just was testing things out and forgot to remove it
dostrander
force-pushed
the
dostrander/issue-1181
branch
from
c3c57a3 to
ff351e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIDimmingViewlooks to be replaced with_UITouchFallbackViewin iOS 14. This PR allows us to fallback to_UITouchFallbackViewwhenUIDImmingViewisn't found.