Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation replace:state has corner cases #306

Closed
haata opened this issue Jan 13, 2019 · 0 comments
Closed

Animation replace:state has corner cases #306

haata opened this issue Jan 13, 2019 · 0 comments
Assignees
@haata
Labels
bug K-Type Kira
Milestone
v0.5.5

Comments

@haata
Copy link
Member

haata commented Jan 13, 2019

  • Device:

Kira

  • Firmware Origin:

controller.git

  • OS:

Linux

  • Version:

0.5.3

  • Reproduction Steps:

Use a replace:state macro quickly (i.e. missing some state transition)

  • Resulting Issue:

Odd animation behaviour.
@haata haata self-assigned this Jan 13, 2019
@haata haata added the bug label Jan 13, 2019
@haata haata added the Kira label Jan 28, 2019
@haata haata added this to the v0.5.5 milestone Jan 30, 2019
@haata haata added the K-Type label Mar 14, 2019
haata added a commit that referenced this issue Mar 17, 2019
@haata
Fixing replace conditions
51b1fb2 
- Was not exiting switch/case correctly (might have fallen through
unexpectedly)
- Added condition to replace:state where the index must also be matched
(should make it more useful)
- Should fix Issue #306
@haata haata closed this as completed Mar 17, 2019
smasher816 pushed a commit to smasher816/controller that referenced this issue Mar 24, 2019
@haata @smasher816
Fixing replace conditions
bfe4558 
- Was not exiting switch/case correctly (might have fallen through
unexpectedly)
- Added condition to replace:state where the index must also be matched
(should make it more useful)
- Should fix Issue kiibohd#306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haata haata

Labels
bug K-Type Kira
Projects
None yet
Milestone
v0.5.5
Development

No branches or pull requests
1 participant
@haata