Skip to content

Commit 4b64083

Browse files
Rexogamerkikoso
authored andcommitted
fix: turn off build IDs for reproducibility (facebook#53089)
Summary: these cause issues for apps that want to be "reproducible" (i.e. the same code leads to the same output, which can be helpful for detemining if there's been any tampering or similar). see also https://gitlab.com/IzzyOnDroid/repo/-/wikis/Reproducible-Builds/RB-Hints-for-Developers#no-funny-build-time-generated-ids I'm not exactly sure why this was set. it seems to have been introduced in facebook@e3830dd without any (public) explanation as to why it was needed? ## Changelog: [ANDROID] [FIXED] - Turned off build IDs for native libraries, fixing issues with reproducibility Pull Request resolved: facebook#53089 Test Plan: I've successfully used similar patches in my own app for a while. Reviewed By: cipolleschi Differential Revision: D79718924 Pulled By: cortinico fbshipit-source-id: 7c609fa0b5b305cb759586fb1c7f332589ca9cc7
1 parent 2ef9e98 commit 4b64083

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

packages/react-native/ReactAndroid/src/main/jni/CMakeLists.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@ if(CCACHE_FOUND)
2929
set_property(GLOBAL PROPERTY RULE_LAUNCH_LINK ccache)
3030
endif(CCACHE_FOUND)
3131

32-
# Make sure every shared lib includes a .note.gnu.build-id header
33-
add_link_options(-Wl,--build-id)
34-
3532
function(add_react_android_subdir relative_path)
3633
add_subdirectory(${REACT_ANDROID_DIR}/${relative_path} ReactAndroid/${relative_path})
3734
endfunction()

0 commit comments

Comments
 (0)