fix: turn off build IDs for reproducibility #53089
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these cause issues for apps that want to be "reproducible" (i.e. the same code leads to the same output, which can be helpful for detemining if there's been any tampering or similar). see also https://gitlab.com/IzzyOnDroid/repo/-/wikis/Reproducible-Builds/RB-Hints-for-Developers#no-funny-build-time-generated-ids I'm not exactly sure why this was set. it seems to have been introduced in facebook@e3830dd without any (public) explanation as to why it was needed?
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
cortinico
approved these changes
Aug 6, 2025
Contributor
cortinico
left a comment
cortinico
left a comment
There was a problem hiding this comment.
Yup we should be able to merge this one
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D79718924. |
Contributor
|
@cortinico merged this pull request in 4b8dbe7. |
Collaborator
|
This pull request was successfully merged by @Rexogamer in 4b8dbe7 When will my fix make it into a release? | How to file a pick request? |
kikoso
pushed a commit
to kikoso/react-native
that referenced
this pull request
Aug 26, 2025
Summary: these cause issues for apps that want to be "reproducible" (i.e. the same code leads to the same output, which can be helpful for detemining if there's been any tampering or similar). see also https://gitlab.com/IzzyOnDroid/repo/-/wikis/Reproducible-Builds/RB-Hints-for-Developers#no-funny-build-time-generated-ids I'm not exactly sure why this was set. it seems to have been introduced in facebook@e3830dd without any (public) explanation as to why it was needed? ## Changelog: [ANDROID] [FIXED] - Turned off build IDs for native libraries, fixing issues with reproducibility Pull Request resolved: facebook#53089 Test Plan: I've successfully used similar patches in my own app for a while. Reviewed By: cipolleschi Differential Revision: D79718924 Pulled By: cortinico fbshipit-source-id: 7c609fa0b5b305cb759586fb1c7f332589ca9cc7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
these cause issues for apps that want to be "reproducible" (i.e. the same code leads to the same output, which can be helpful for detemining if there's been any tampering or similar). see also https://gitlab.com/IzzyOnDroid/repo/-/wikis/Reproducible-Builds/RB-Hints-for-Developers#no-funny-build-time-generated-ids
I'm not exactly sure why this was set. it seems to have been introduced in e3830dd without any (public) explanation as to why it was needed?
Changelog:
[ANDROID] [FIXED] - Turned off build IDs for native libraries, fixing issues with reproducibility
Test Plan:
I've successfully used similar patches in my own app for a while.