Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixit ticket updates, added loading indicator, style adjustments #2

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jhub_apps/static/css/index.css

Large diffs are not rendered by default.

81 changes: 54 additions & 27 deletions jhub_apps/static/js/index.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions ui/jest.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ const config: JestConfigWithTsJest = {
'^.+.(svg|css|styl|less|sass|scss|png|jpg|ttf|woff|woff2)$':
'jest-transform-stub',
// Paths from tsconfig.json
'^src/(.*)$': '<rootDir>/src/$1',
'^@src/components': '<rootDir>/src/components',
'^@src/data/(.*)$': '<rootDir>/src/data/$1',
'^@src/features/(.*)$': '<rootDir>/src/features/$1',
Expand Down
78 changes: 75 additions & 3 deletions ui/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"@emotion/react": "^11.11.4",
"@emotion/styled": "^11.11.5",
"@mui/icons-material": "^5.15.15",
"@mui/lab": "^5.0.0-alpha.170",
"@mui/material": "5.15.10",
"@tanstack/react-query": "5.37.1",
"axios": "1.6.8",
Expand Down
22 changes: 21 additions & 1 deletion ui/src/components/app-card/app-card.css
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
box-shadow: 0px 1px 2px rgba(210, 210, 207, 0.7);
}

.card.service {
height: 224px;
}

.card > a {
text-decoration: none;
}
Expand Down Expand Up @@ -158,10 +162,26 @@
padding: 0.5rem 1rem 1rem;
}

/* .card-header {
display: flex;
align-items: center;
}

.inline.relative.iconic {
display: flex;
align-items: center;
margin-right: 8px;
}

.card-title {
display: flex;
align-items: center;
} */

.card-content-content .card-inner-content .iconic {
font-size: 1rem !important;
position: relative;
top: 3px;
top: 2px;
margin-right: 8px;
}

Expand Down
48 changes: 27 additions & 21 deletions ui/src/components/app-card/app-card.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,11 @@ export const AppCard = ({
};

return (
<Box className="card" id={`card-${id}`} tabIndex={0}>
<Box
className={`card ${isAppCard ? '' : 'service'}`}
id={`card-${id}`}
tabIndex={0}
>
<Link href={url}>
<Card id={`card-${id}`} tabIndex={0} className="Mui-card">
<div
Expand Down Expand Up @@ -220,32 +224,34 @@ export const AppCard = ({
label={framework}
id={`chip-${id}`}
size="small"
sx={{ mb: '8px' }}
sx={{ mb: '8px', fontWeight: 600 }}
/>
</div>
</div>
) : (
<></>
)}
<span className="inline relative iconic">{getIcon()}</span>
<Typography
gutterBottom
variant="h5"
component="div"
className="card-title"
sx={{ position: 'relative', top: '5px' }}
>
<Tooltip title={title} placement="top-start">
<span
className="card-content-truncate"
style={{
maxWidth: '220px',
}}
>
{title}
</span>
</Tooltip>
</Typography>
<div>
<span className="inline relative iconic">{getIcon()}</span>
<Typography
gutterBottom
variant="h5"
component="div"
className="card-title"
sx={{ position: 'relative', top: '5px' }}
>
<Tooltip title={title} placement="top-start">
<span
className="card-content-truncate"
style={{
maxWidth: '220px',
}}
>
{title}
</span>
</Tooltip>
</Typography>
</div>
<Typography
variant="body2"
color="text.secondary"
Expand Down
2 changes: 1 addition & 1 deletion ui/src/components/app-form/app-form.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ export const AppForm = ({ id }: AppFormProps): React.ReactElement => {
: 'transparent',
backgroundColor:
description.length > 0 || isFocused
? '#ffffff'
? '#fafafa'
: 'transparent',
}}
>
Expand Down
8 changes: 6 additions & 2 deletions ui/src/components/status-chip/status-chip.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Chip } from '@mui/material';
interface StatusChipProps {
status: string;
size?: 'small' | 'medium';
}
const getStatusStyles = (status: string) => {
let styles;
Expand Down Expand Up @@ -35,10 +36,13 @@ const getStatusStyles = (status: string) => {
return styles;
};

export const StatusChip = ({ status }: StatusChipProps): React.ReactElement => (
export const StatusChip = ({
status,
size = 'small',
}: StatusChipProps): React.ReactElement => (
<Chip
label={status || 'Default'}
size="small"
size={size}
sx={{ fontWeight: 600, fontSize: '12px', ...getStatusStyles(status) }}
/>
);
Expand Down
3 changes: 3 additions & 0 deletions ui/src/index.css
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
}

/* Global Styling */
html {
background: #fafafa;
}
main {
margin: 24px 0;
}
Expand Down
20 changes: 19 additions & 1 deletion ui/src/pages/home/apps-section/app-table/app-table.css
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
.align-vertical-center {
vertical-align: middle;
position: relative;
top: -6px; /* Adjust this value as needed */
}

.icon-button {
padding: 0 20px !important;
}

.icon-text {
padding-left: 1rem;
padding-left: 0.5rem;
position: relative;
top: -3px;
}
Expand All @@ -19,6 +25,7 @@

.actions .action-button:hover {
background-color: transparent;
border-radius: 50%;
}

.actions button.button-icon {
Expand All @@ -27,6 +34,13 @@

.actions button.button-icon:hover {
background-color: transparent;
border-radius: 50%;
}

.action-button {
min-width: 0px !important;
border-radius: 50% !important;
margin: 0 1rem !important;
}

.truncate {
Expand All @@ -39,3 +53,7 @@
.MuiDataGrid-menuIcon.base-Popper-root.MuiDataGrid-menu {
display: none;
}

.app-header th {
font-weight: 600;
}
Loading
Loading