Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kpm: Cloudsmith download fix #188

Merged
merged 3 commits into from
Apr 13, 2021
Merged

kpm: Cloudsmith download fix #188

merged 3 commits into from
Apr 13, 2021

Conversation

pierre
Copy link
Member

@pierre pierre commented Apr 10, 2021

Per @lskillen, don't assume a maven-metadata.xml exists for non-SNAPSHOT artifacts.

I've added a regression test on GitHub Actions for this, which pulls from a Cloudsmith test repository:

  1. A released artifact
  2. A SNAPSHOT artifact (with multiple uploads)

Don't expect a maven-metadata.xml for non SNAPSHOT artifacts.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
@pierre pierre requested a review from sbrossie April 10, 2021 12:18
@sbrossie
Copy link
Member

Just tried and it seems like this is working fine 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants