Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database Migrations DDL link out of date #63

Closed
ccostes opened this issue Apr 26, 2019 · 1 comment · Fixed by #64
Closed

Database Migrations DDL link out of date #63

ccostes opened this issue Apr 26, 2019 · 1 comment · Fixed by #64
Assignees

Comments

@ccostes
Copy link

ccostes commented Apr 26, 2019

The database migrations guide (userguide/tutorials/database_migrations.adoc) has a link for the "latest" ddl file, along with a link to the http://killbill.io/downloads/ page. Both of these sources contain the DDL file for Kill Bill version 0.18, which is out of date. (the whole downloads page is for version 0.18, but that's a separate issue)

Might be best to just point to the github source (which is actually the first result if you google "kill bill ddl") to avoid needing to update it for each release.

pierre added a commit that referenced this issue Apr 30, 2019
See #63.

Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>
@pierre pierre self-assigned this Apr 30, 2019
@pierre
Copy link
Member

pierre commented Apr 30, 2019

(the whole downloads page is for version 0.18, but that's a separate issue)

Oops 🙊This is a legacy page, it shouldn't be referenced anymore.

Might be best to just point to the github source (which is actually the first result if you google "kill bill ddl") to avoid needing to update it for each release.

Because of our project structure, there isn't a single DDL file (not sure which link Google shows you, but I'm seeing https://docs.killbill.io/0.16/getting_started.html 😕).

I've fixed the script generating the directory in 39d992c. PR: #64.

Thanks for the report!

Related: killbill/killbill-cloud#66

@pierre pierre closed this as completed in #64 May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants