Make taxRate part of item details for all tax items added to the invoice #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singh-sukhvir
requested changes
Jul 23, 2024
src/main/java/org/killbill/billing/plugin/vertex/VertexTaxCalculator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/killbill/billing/plugin/vertex/VertexTaxCalculator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/killbill/billing/plugin/vertex/VertexTaxCalculator.java
Outdated
Show resolved
Hide resolved
src/test/java/org/killbill/billing/plugin/vertex/VertexTaxCalculatorTest.java
Outdated
Show resolved
Hide resolved
singh-sukhvir
approved these changes
Jul 24, 2024
src/main/java/org/killbill/billing/plugin/vertex/VertexTaxCalculator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/killbill/billing/plugin/vertex/VertexTaxCalculator.java
Outdated
Show resolved
Hide resolved
src/test/java/org/killbill/billing/plugin/vertex/VertexTaxCalculatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/killbill/billing/plugin/vertex/VertexTaxCalculatorTest.java
Show resolved
Hide resolved
src/test/java/org/killbill/billing/plugin/vertex/VertexTaxCalculatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/killbill/billing/plugin/vertex/VertexTaxCalculatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/killbill/billing/plugin/vertex/VertexTaxCalculatorTest.java
Show resolved
Hide resolved
vlaskhilkevich
changed the title
vlaskhilkevich
force-pushed
the
tax-rate-in-item-details
branch
from
3ed2e61 to
36a731c
Compare
singh-sukhvir
requested changes
Jul 26, 2024
src/main/java/org/killbill/billing/plugin/vertex/VertexTaxCalculator.java
Outdated
Show resolved
Hide resolved
src/test/java/org/killbill/billing/plugin/vertex/VertexTaxCalculatorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/killbill/billing/plugin/vertex/VertexTaxCalculatorTest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/killbill/billing/plugin/vertex/VertexTaxCalculator.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Invoice's
itemDetailsfield to preserve for TAX items effective tax rate obtained from vertex as json object in the format (example):{"taxRate":0.09975}This field can be used for more information if needed in the future