Do not overwrite itemDetails for invoice tax items which contains some value there #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlaskhilkevich
changed the title
vlaskhilkevich
changed the title
Comment on lines
41
to
52
| public TaxItemDetails(@Nonnull final Double taxRate, @Nullable final UsageConsumableInArrearAggregate usageDetail) { | ||
| this(taxRate, usageDetail != null ? usageDetail.getTierDetails() : null, usageDetail != null ? usageDetail.getAmount() : null); | ||
| } | ||
|
|
||
| @JsonCreator | ||
| public TaxItemDetails(@JsonProperty("taxRate") final Double taxRate, | ||
| @JsonProperty("tierDetails") List<UsageConsumableInArrearTierUnitAggregate> tierDetails, | ||
| @JsonProperty("amount") BigDecimal amount) { | ||
| this.tierDetails = tierDetails; | ||
| this.amount = amount; | ||
| this.taxRate = taxRate; | ||
| } |
There was a problem hiding this comment.
what if Killbill adds more details than just tiers and amount. itemDetails is a json string ( it could contain any information not just tiers/amount). Can't we do something like below without even having to use object TaxItemDetails for the same.
ObjectMapper mapper = new ObjectMapper();
JsonNode actualObj = mapper. readTree(itemDetails);
((ObjectNode) actualObj).put("taxRate", 1.0);
There was a problem hiding this comment.
I think that's great suggestion 👍, I didn't like the way how vertex plugin became exposed to invoice module implementation details of KB and it's specific version defined in pom.xml, missed this simple approach.
There was a problem hiding this comment.
fixed in 028ba4a
…rsion without vulnerability
vlaskhilkevich
commented
Aug 13, 2024
pom.xml
Outdated
| </dependency> | ||
| <dependency> | ||
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| <version>2.13.4.1</version> |
There was a problem hiding this comment.
had to update jackson-annotations and jackson-core to be compatible (as to upperBind version enforcements warning)
vlaskhilkevich
changed the title
vlaskhilkevich
changed the title
vlaskhilkevich
changed the title
vlaskhilkevich
changed the title
andrenpaes
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR -