fix(upgrade): Always upgrade compatible dependencies #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of feedback on `cargo-upgrade` being merged into `cargo`, we are looking into how we can make `upgrade` fit into `update` or be a direct replacement for `update`. In doing so, the "skip compatible by default" workflow doesn't quite fit the same. Similarly, manifests, in theory, will always match the lock file, so there will be less of a reason to upgrade the manifests only. We'll need to re-open killercup#552 and killercup#297 until we figure out how we want to handle this.
This was referenced Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of feedback on
cargo-upgradebeing merged intocargo, we are looking into how we can makeupgradefit intoupdateor be a direct replacement forupdate. In doing so, the "skip compatible by default" workflow doesn't quite fit the same. Similarly, manifests, in theory, will always match the lock file, so there will be less of a reason to upgrade the manifests only.We'll need to re-open #552 and #297 until we figure out how we want to handle this.