cargo add: Infer crate name from path/git repo
#83
Conversation
| Add a dependency to a Cargo.toml manifest file. | ||
| Add a dependency to a Cargo.toml manifest file. If <crate> is a github or gitlab repository url, or | ||
| a local path, `cargo add` will try to authomaticall get the crate name and authomatically set the | ||
| appropriate `--git` or `--path`. |
There was a problem hiding this comment.
(Tiny typo: It's spelled 'automatically'. Also, please write URL in uppercase.)
|
Thank you! I just had a quick look at this—It looks good so far (I added a comment about a typo), but I haven't tested it locally. This changes cargo-add quick significantly, so I would like to have some more tests for this.
I'm not sure this PR (#67) will be merged. but I would like to refactor the fetch code in the future. No need to wait for this, though. Regarding your I'll be on vacation the next weeks, I'll probably check in every few days, though. |
|
Thanks for the comments! I will probably not be able to do much until Tuesday, I will push the changes concerning Option/Result as soon as possible. And then I will implement some new tests, do you have some that you would particularly like to see? |
|
Changes Unknown when pulling e5f3ad8 on mseri:add-recognise-path-v1 into * on killercup:master*. |
|
I have cleaned the code, replaced Option to Result, and modified how I deal with paths -- although I am not convinced that I am doing it in the best way (I have left a FIXME there). I also added tests concerning success and failure. If you think that we should add more, just let me know what you believe it's missing. Setting the environment variable "NO_REMOTE_CARGO_TEST" allows to skip the new tests requiring a working network connection. This version seems to work on my computer (osx 10.11) using multirust with stable and beta. I don't understand where the SIGSEV in travis-unstable comes from. Do you have any guess? |
|
@killercup any comment on this PR? I am using it since the latest commit and had no issue yet |
|
Sorry for the radio silence, I didn't have as much time as I had hoped… I'm not sure setting a
No idea. Don't worry about it, I'll probably bump the nightly version later anyway to get a newer clippy. |
| @@ -0,0 +1,7 @@ | |||
| [package] | |||
There was a problem hiding this comment.
Can you rename this to Cargo.toml.sample? We renamed all the other Cargo.toml files in the fixtures directory because it was confusing cargo install. Thanks!
|
No problem. I am going to add a cargo feature then. Edit: I have updated the PR incorporating your comments. |
|
Cool, thank you! Let's land this PR now 😄 @homu r+ |
|
📌 Commit d227f01 has been approved by |
|
⚡ Test exempted - status |
`cargo add`: Infer crate name from path/git repo This is an attempt to address issue #14. There are still few FIXME in the code (in part due to me waiting for the hyper PR to be merged).
This is an attempt to address issue #14.
There are still few FIXME in the code (in part due to me waiting for the hyper PR to be merged).