Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a function to parse pulldown-mark Events #2

Merged
merged 1 commit into from
May 30, 2017

Conversation

mcarton
Copy link
Collaborator

@mcarton mcarton commented May 30, 2017

This might be useful for a tool (who said Clippy?) that already parses markdown using pulldown-cmark in order not to parse the documentation twice.

Cc https://github.com/Manishearth/rust-clippy/pull/1799.

You might want that to be hidden behind a feature flag?

This might be useful for a tool (who said Clippy?) that already parses
markdown using `pulldown-cmark` in order not to parse the documentation
twice.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 97.902% when pulling 5716c08 on mcarton:clippy-req into ae50902 on killercup:master.

@killercup
Copy link
Owner

Oh yes, absolutely!

You might want that to be hidden behind a feature flag?

This is not the final API probably, so let's just add it as a pub function until we settle on a nicer design. I think I even have a branch somewhere where I tried to impl From for &str and T: Iterator<Event<'a>> :D

@killercup killercup merged commit 5ca1747 into killercup:master May 30, 2017
@mcarton mcarton deleted the clippy-req branch May 30, 2017 18:41
@mcarton
Copy link
Collaborator Author

mcarton commented May 30, 2017

🎉 Could you publish a v0.1 on crates.io so I can start working on Clippy integration?

@killercup
Copy link
Owner

Sure, coming right up. Want me to add you as a collaborator/crate owner?

@killercup
Copy link
Owner

Also, maybe #1 can get resurrected? cc @hobofan

@mcarton
Copy link
Collaborator Author

mcarton commented May 30, 2017

Sure, coming right up. Want me to add you as a collaborator/crate owner?

Sure!

@killercup
Copy link
Owner

https://crates.io/crates/docstrings 💥 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants