Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: monitor empty consensus block #89

Merged
merged 14 commits into from
Nov 20, 2024
Merged

Conversation

quertc
Copy link
Contributor

@quertc quertc commented Nov 20, 2024

Add monitoring for empty consensus blocks. Important for chains where empty CL blocks aren't broadcasted to execution layer (e.g. Berachain), affecting validator's EL uptime.

  • Added empty_blocks prometheus counter
  • Added empty block indicator (🟡) in logs
  • Added tests

Copy link
Member

@MattKetmo MattKetmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this 👍

I just left a quick comment to fix the test.

pkg/watcher/block_test.go Outdated Show resolved Hide resolved
Co-authored-by: Matt Ketmo <matthieu@moquet.net>
@quertc
Copy link
Contributor Author

quertc commented Nov 20, 2024

Done!

@quertc
Copy link
Contributor Author

quertc commented Nov 20, 2024

I'll also update the docs soon (edit: done).

@MattKetmo MattKetmo changed the title feat: add prometheus metrics for empty consensus block feat: monitor empty consensus block Nov 20, 2024
@MattKetmo MattKetmo merged commit c4d7ca1 into kilnfi:main Nov 20, 2024
3 of 5 checks passed
@MattKetmo MattKetmo added the feature New feature or request label Nov 21, 2024
Copy link

@Sturgeontara06 Sturgeontara06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants