Merge pull request #2 from kimLalilo/add-pr-template

add pull_request template
kimLalilo · Jun 25, 2024 · d797ebf · d797ebf
2 parents 71b261d + 9f9fded
commit d797ebf
Show file tree

Hide file tree

Showing 6 changed files with 52 additions and 154 deletions.
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
@@ -0,0 +1,48 @@
+_If you are not comfortable with Markdown, use the preview button and [here](https://enterprise.github.com/downloads/en/markdown-cheatsheet.pdf) is a cheat sheet to help you!_
+
+
+## Description
+Please include a summary of the changes and the related issue. Please also include relevant motivation and context.  
+
+## Key details
+### Notion document
+Include URL of the Notion document that contains the design details for this PR.
+
+### Type of change
+Delete any options that are not relevant.
+- [ ] Bug fix (non-breaking change which fixes an issue)
+- [ ] New feature (non-breaking change which adds functionality)
+- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
+- [ ] This change requires a documentation update
+
+### Priority
+Select one
+- [ ] HIGH (please approve immediately!)
+- [ ] Medium (please approve in 1-2 days)
+- [ ] low (can be approved within 1 week)
+
+### Risk
+Select one
+- [ ] HIGH (contains complex logic that may introduce breaking changes)
+- [ ] Medium (moderate to low risk, but any potential errors can be remedied quickly)
+- [ ] low (very low likelihood of introducing breaking changes)
+
+## Building
+Provide more details, if necessary, on how to build the changes made in this PR.
+
+## Quality Assurance
+Describe the QA process you followed for this PR. 
+
+What would be impacted if the changes introduce non-breaking errors?
+
+## Validation
+Add validation steps here if it qualifies.
+
+## Checklist:
+- [ ] I have checked whether my modifications impact any data shared to Renaissance (models in data_sent_to_renaissance folder)
+- [ ] If yes, I have put a message on #renaissance-data-exchange to warn external data consumers so they can anticipate
+- [ ] My code follows the style guidelines of this project
+- [ ] I have performed a self-review of my code
+- [ ] I have made corresponding changes to the documentation
+- [ ] New and existing dbt tests pass locally with my changes
+- [ ] when there is a schema change, check if full refresh is necessary
diff --git a/.github/workflows/cd_prod.yml b/.github/workflows/cd_prod.yml
@@ -29,51 +29,3 @@ jobs:
         run: uv pip install -r requirements.txt --system
       - name: Run dbt Cloud job
         run: python3 .github/workflows/scripts/dbt_cloud_run_job.py
-
-  run_bigquery:
-    name: dbt Cloud Deploy Prod BigQuery
-    runs-on: macos-latest
-
-    env:
-      DBT_ACCOUNT_ID: 188483
-      DBT_PROJECT_ID: 275557
-      DBT_PR_JOB_ID: 553247
-      DBT_API_KEY: ${{ secrets.DBT_CLOUD_API_KEY }}
-      DBT_JOB_CAUSE: "GitHub Actions Request"
-      DBT_JOB_BRANCH: main
-
-    steps:
-      - uses: "actions/checkout@v4"
-      - uses: "actions/setup-python@v5"
-        with:
-          python-version: "3.12"
-      - name: Install uv
-        run: python3 -m pip install uv
-      - name: Install deps
-        run: uv pip install -r requirements.txt --system
-      - name: Run dbt Cloud job
-        run: python3 .github/workflows/scripts/dbt_cloud_run_job.py
-
-  run_postgres:
-    name: dbt Cloud Deploy Prod Postgres
-    runs-on: macos-latest
-
-    env:
-      DBT_ACCOUNT_ID: 188483
-      DBT_PROJECT_ID: 288405
-      DBT_PR_JOB_ID: 577871
-      DBT_API_KEY: ${{ secrets.DBT_CLOUD_API_KEY }}
-      DBT_JOB_CAUSE: "GitHub Actions Request"
-      DBT_JOB_BRANCH: main
-
-    steps:
-      - uses: "actions/checkout@v4"
-      - uses: "actions/setup-python@v5"
-        with:
-          python-version: "3.12"
-      - name: Install uv
-        run: python3 -m pip install uv
-      - name: Install deps
-        run: uv pip install -r requirements.txt --system
-      - name: Run dbt Cloud job
-        run: python3 .github/workflows/scripts/dbt_cloud_run_job.py
diff --git a/.github/workflows/cd_staging.yml b/.github/workflows/cd_staging.yml
@@ -29,51 +29,3 @@ jobs:
         run: uv pip install -r requirements.txt --system
       - name: Run dbt Cloud job
         run: python3 .github/workflows/scripts/dbt_cloud_run_job.py
-
-  run_bigquery:
-    name: dbt Cloud Deploy Staging BigQuery
-    runs-on: macos-latest
-
-    env:
-      DBT_ACCOUNT_ID: 188483
-      DBT_PROJECT_ID: 275557
-      DBT_PR_JOB_ID: 560539
-      DBT_API_KEY: ${{ secrets.DBT_CLOUD_API_KEY }}
-      DBT_JOB_CAUSE: "GitHub Actions Request"
-      DBT_JOB_BRANCH: staging
-
-    steps:
-      - uses: "actions/checkout@v4"
-      - uses: "actions/setup-python@v5"
-        with:
-          python-version: "3.12"
-      - name: Install uv
-        run: python3 -m pip install uv
-      - name: Install deps
-        run: uv pip install -r requirements.txt --system
-      - name: Run dbt Cloud job
-        run: python3 .github/workflows/scripts/dbt_cloud_run_job.py
-
-  run_postgres:
-    name: dbt Cloud Deploy Staging Postgres
-    runs-on: macos-latest
-
-    env:
-      DBT_ACCOUNT_ID: 188483
-      DBT_PROJECT_ID: 288405
-      DBT_PR_JOB_ID: 577883
-      DBT_API_KEY: ${{ secrets.DBT_CLOUD_API_KEY }}
-      DBT_JOB_CAUSE: "GitHub Actions Request"
-      DBT_JOB_BRANCH: staging
-
-    steps:
-      - uses: "actions/checkout@v4"
-      - uses: "actions/setup-python@v5"
-        with:
-          python-version: "3.12"
-      - name: Install uv
-        run: python3 -m pip install uv
-      - name: Install deps
-        run: uv pip install -r requirements.txt --system
-      - name: Run dbt Cloud job
-        run: python3 .github/workflows/scripts/dbt_cloud_run_job.py
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -29,53 +29,3 @@ jobs:
         run: uv pip install -r requirements.txt --system
       - name: Run dbt Cloud job
         run: python3 .github/workflows/scripts/dbt_cloud_run_job.py
-
-  run_bigquery:
-    name: dbt Cloud PR CI BigQuery
-    runs-on: macos-latest
-
-    env:
-      DBT_ACCOUNT_ID: 188483
-      DBT_PROJECT_ID: 275557
-      DBT_PR_JOB_ID: 561096
-      DBT_API_KEY: ${{ secrets.DBT_CLOUD_API_KEY }}
-      DBT_JOB_CAUSE: "GitHub Actions Request"
-      DBT_JOB_BRANCH: ${{ github.head_ref }}
-      DBT_JOB_SCHEMA_OVERRIDE: dbt_jsdx__pr_${{ github.head_ref}}
-
-    steps:
-      - uses: "actions/checkout@v4"
-      - uses: "actions/setup-python@v5"
-        with:
-          python-version: "3.12"
-      - name: Install uv
-        run: python3 -m pip install uv
-      - name: Install deps
-        run: uv pip install -r requirements.txt --system
-      - name: Run dbt Cloud job
-        run: python3 .github/workflows/scripts/dbt_cloud_run_job.py
-
-  run_postgres:
-    name: dbt Cloud PR CI Postgres
-    runs-on: macos-latest
-
-    env:
-      DBT_ACCOUNT_ID: 188483
-      DBT_PROJECT_ID: 288405
-      DBT_PR_JOB_ID: 577887
-      DBT_API_KEY: ${{ secrets.DBT_CLOUD_API_KEY }}
-      DBT_JOB_CAUSE: "GitHub Actions Request"
-      DBT_JOB_BRANCH: ${{ github.head_ref }}
-      DBT_JOB_SCHEMA_OVERRIDE: dbt_jsdx__pr_${{ github.head_ref}}
-
-    steps:
-      - uses: "actions/checkout@v4"
-      - uses: "actions/setup-python@v5"
-        with:
-          python-version: "3.12"
-      - name: Install uv
-        run: python3 -m pip install uv
-      - name: Install deps
-        run: uv pip install -r requirements.txt --system
-      - name: Run dbt Cloud job
-        run: python3 .github/workflows/scripts/dbt_cloud_run_job.py
diff --git a/dbt_project.yml b/dbt_project.yml
@@ -24,10 +24,6 @@ clean-targets:
 vars:
   "dbt_date:time_zone": "America/Los_Angeles"
 
-seeds:
-  jaffle_shop:
-    +schema: raw
-
 models:
   jaffle_shop:
     staging:

diff --git a/models/staging/__sources.yml b/models/staging/__sources.yml
@@ -4,10 +4,10 @@ sources:
   - name: ecom
     schema: raw
     description: E-commerce data for the Jaffle Shop
-    freshness:
-      warn_after:
-        count: 24
-        period: hour
+    #freshness:
+      #warn_after:
+        #count: 24
+        #period: hour
     tables:
       - name: raw_customers
         description: One record per person who has purchased one or more items