Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit requirements #3

Merged
merged 1 commit into from
Jul 16, 2024
Merged

commit requirements #3

merged 1 commit into from
Jul 16, 2024

Conversation

kimLalilo
Copy link
Owner

If you are not comfortable with Markdown, use the preview button and here is a cheat sheet to help you!

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Key details

Notion document

Include URL of the Notion document that contains the design details for this PR.

Type of change

Delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Priority

Select one

  • HIGH (please approve immediately!)
  • Medium (please approve in 1-2 days)
  • low (can be approved within 1 week)

Risk

Select one

  • HIGH (contains complex logic that may introduce breaking changes)
  • Medium (moderate to low risk, but any potential errors can be remedied quickly)
  • low (very low likelihood of introducing breaking changes)

Building

Provide more details, if necessary, on how to build the changes made in this PR.

Quality Assurance

Describe the QA process you followed for this PR.

What would be impacted if the changes introduce non-breaking errors?

Validation

Add validation steps here if it qualifies.

Checklist:

  • I have checked whether my modifications impact any data shared to Renaissance (models in data_sent_to_renaissance folder)
  • If yes, I have put a message on #renaissance-data-exchange to warn external data consumers so they can anticipate
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • New and existing dbt tests pass locally with my changes
  • when there is a schema change, check if full refresh is necessary

@kimLalilo kimLalilo merged commit cab4527 into main Jul 16, 2024
0 of 2 checks passed
@kimLalilo kimLalilo deleted the update-dev-env branch July 16, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant