Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve #21 #22

Closed
wants to merge 1 commit into from
Closed

resolve #21 #22

wants to merge 1 commit into from

Conversation

JimmySorza
Copy link

Added case for DELETE in the index.js with the same return of CREATE. This is because The response to DELETE must be like { data: { id: 123, ... } }

@afilp
Copy link
Contributor

afilp commented Dec 19, 2018

Hi! Can this be merged? Without this, this lib does not work for DELETE in React Admin 2+

@JimmySorza
Copy link
Author

@afilp the reason must be this: https://github.com/kimkha/aor-loopback#not-maintained-anymore

With new react-admin, please use loopback-component-react-admin instead
Because of recent changes of admin-on-rest, this module will only support version 0.9.0 (or later) of admin-on-rest.

Then I close this Pull request.

@JimmySorza JimmySorza closed this Dec 19, 2018
@afilp
Copy link
Contributor

afilp commented Dec 19, 2018

@JimmySorza Thank you! So I assume we must follow that other package now. Thanks @kimkha for your work.

@afilp
Copy link
Contributor

afilp commented Dec 19, 2018

@JimmySorza Ummm, now I am confused, there is another package also:

https://github.com/darthwesker/react-admin-loopback

And actually this is the one shown in "Data Providers":
https://marmelab.com/react-admin/DataProviders.html

@JimmySorza
Copy link
Author

JimmySorza commented Dec 19, 2018

@afilp you right!, I did not know about that other package, so you can use any package you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants