Update CMakeLists.txt #260
Conversation
- Remove unused install folder for includes - Reorga set for bin outputs
WalkthroughThe pull request modifies the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CMakeLists.txt (1)
27-31: Consider adding comments for output directory configurationConsider adding more descriptive comments to explain the purpose of each output directory:
# Set the default build output folders -SET( CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_HOME_DIRECTORY}/lib ) -SET( CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_HOME_DIRECTORY}/lib ) -SET( CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_HOME_DIRECTORY}/bin ) +# Libraries (.so, .dll) go to lib/ +SET( CMAKE_LIBRARY_OUTPUT_DIRECTORY ${CMAKE_HOME_DIRECTORY}/lib ) +# Static libraries (.a, .lib) go to lib/ +SET( CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_HOME_DIRECTORY}/lib ) +# Executables go to bin/ +SET( CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_HOME_DIRECTORY}/bin )
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CMakeLists.txt(1 hunks)
🔇 Additional comments (1)
CMakeLists.txt (1)
27-31: LGTM! Output directory configuration looks good.
The new output directory settings provide a clear and consistent structure for build artifacts:
- Libraries and archives go to
${CMAKE_HOME_DIRECTORY}/lib - Executables go to
${CMAKE_HOME_DIRECTORY}/bin
Let's verify that no subdirectories override these settings:
✅ Verification successful
Output directory configuration is safe and correctly set
The verification shows that:
- The output directory settings are only defined once in the root CMakeLists.txt
- These settings are set before any subdirectories are added, ensuring they propagate correctly
- The project has a proper structure with subdirectories (src, samples, test, etc.) that inherit these settings
- The settings align with the cached install directories (LIB_INSTALL_DIR="lib" and BIN_INSTALL_DIR="bin")
The removal of INCLUDE_INSTALL_DIR is safe as:
- The project still maintains proper include directories through INCLUDE_DIRECTORIES command
- No install commands were found that depend on INCLUDE_INSTALL_DIR
- The change focuses on build outputs rather than installation paths
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for potential output directory overrides in subdirectories
rg -l "SET.*CMAKE_(LIBRARY|ARCHIVE|RUNTIME)_OUTPUT_DIRECTORY" --type cmake
Length of output: 91
Script:
#!/bin/bash
# Let's check if there are any other CMake files that might indirectly affect output directories
fd -e cmake -x cat {} | grep -i "set.*output.*directory"
Length of output: 60
Script:
#!/bin/bash
# Let's also check for any install commands that might be affected
rg -i "install" --type cmake
Length of output: 965
Script:
#!/bin/bash
# Check if there are any add_subdirectory commands that might need these settings
rg "add_subdirectory" --type cmake
Length of output: 34
Script:
#!/bin/bash
# Let's check the content of CMakeLists.txt to understand the project structure
cat CMakeLists.txt
Length of output: 5151
Script:
#!/bin/bash
# Let's also check for any subdirectories that might contain CMake files
fd -t d -d 1
Length of output: 58
|
Summary by CodeRabbit