Skip to content
This repository has been archived by the owner on Apr 26, 2022. It is now read-only.

UploadRequest to provide original xhr request as part of callback par… #35

Merged
merged 4 commits into from
May 28, 2019
Merged

UploadRequest to provide original xhr request as part of callback par… #35

merged 4 commits into from
May 28, 2019

Conversation

manish-tal
Copy link
Contributor

…ameters

@manish-tal manish-tal mentioned this pull request May 24, 2019
Open
@zackify
Copy link
Contributor

zackify commented May 24, 2019

Why is this needed?

@manish-tal
Copy link
Contributor Author

manish-tal commented May 25, 2019 •
edited
Loading

Because I am sending some information in response header and I need that information after files are done uploading. And I think it will be good to make response headers accessible in response returned.

@manish-tal
Copy link
Contributor Author

I have added test cases for headers please review

@zackify
Copy link
Contributor

zackify commented May 27, 2019

Thanks! unfortunately it looks like i dont have permission on this repo. hopefully they grant it back to me, then i can merge

@zackify zackify merged commit c854f8e into kimmelsg:master May 28, 2019
@zackify
Copy link
Contributor

zackify commented May 28, 2019

This is now up! Thanks https://github.com/ConstructionJobs/upload/releases/tag/3.2.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@audiolion audiolion audiolion left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manish-tal @zackify @audiolion @manishk3008