Upgrading to latest addon blueprint #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kimroen any chance you can take a peek at this? It should get this addon into a pretty good state. Let me know if you want any help with maintenance. |
This was referenced Nov 15, 2018
|
I've pulled most of these commits (and equivalent others) into https://github.com/mike-north/ember-cli-document-title-northm and released |
|
Spoke to @kimroen via Twitter. He's on vacation right now, but will look into all PRs once back. |
snewcomer
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades this addon to the latest blueprint, including resolving issues with tests.
This PR likely mandates a major version bump (or, perhaps we should make this 1.0.0??).